Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Multiple Datasource] Expose filterfn in datasource menu component to allow filter data sources before rendering in navigation bar #6261

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 45096bb from #6113.

… allow filter data sources before rendering in navigation bar (#6113)

* expose filterfn in datasource menu component

Signed-off-by: Lu Yu <nluyu@amazon.com>

* add changelog

Signed-off-by: Lu Yu <nluyu@amazon.com>

---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
(cherry picked from commit 45096bb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.26%. Comparing base (1ef53d0) to head (219b937).

Files Patch % Lines
...onents/data_source_menu/data_source_selectable.tsx 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #6261      +/-   ##
==========================================
+ Coverage   67.24%   67.26%   +0.01%     
==========================================
  Files        3338     3338              
  Lines       64628    64634       +6     
  Branches    10341    10344       +3     
==========================================
+ Hits        43462    43476      +14     
+ Misses      18654    18646       -8     
  Partials     2512     2512              
Flag Coverage Δ
Linux_1 31.30% <ø> (ø)
Linux_2 55.39% <ø> (ø)
Linux_3 44.73% <90.00%> (+0.03%) ⬆️
Linux_4 35.26% <0.00%> (-0.01%) ⬇️
Windows_1 31.33% <ø> (ø)
Windows_2 55.35% <ø> (ø)
Windows_3 44.73% <90.00%> (+0.02%) ⬆️
Windows_4 35.26% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BionIT BionIT merged commit b174c91 into 2.x Mar 25, 2024
91 of 92 checks passed
@github-actions github-actions bot deleted the backport/backport-6113-to-2.x branch March 25, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports multiple datasource multiple datasource project seasoned-contributor v2.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants