-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data Explorer] Migrate VisBuilder to Data Explorer #5627
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5627 +/- ##
===========================================
+ Coverage 55.58% 67.60% +12.01%
===========================================
Files 1199 3357 +2158
Lines 24259 65235 +40976
Branches 4087 10520 +6433
===========================================
+ Hits 13485 44100 +30615
- Misses 10133 18565 +8432
- Partials 641 2570 +1929
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
38556f7
to
d7d2e67
Compare
Ongoing and Upcoming TasksMinor Bug Identification: This morning, I noticed a small issue. After saving a visualization in Vis Builder and then reloading it from the Recently Viewed section in the side navigation, the breadcrumb doesn’t display the title correctly. I believe moving Regarding Comment 1: About the suggestion to prefix the slice with the view ID to avoid name conflicts, I’m considering a modification. In the Data Explorer, we could add a prefix, but when retrieving the state, it would be necessary to remove this prefix for use. This means that each time we use a state in Vis Builder, we would run a helper function to remove the prefix. I'm still contemplating this approach. Regarding Comment 2: I just remember we need to add migration state to make sure legacy URLs for Vis Builder continue working after this migration. I will implement a solution similar to what was used during the Discover migration. Performance Improvement: I also noticed some potential improvements in reducing repeated rendering. Next Steps
|
57b6ae9
to
aaa6a7e
Compare
0bf4045
to
327678b
Compare
This PR completes Task 1 and 2 in opensearch-project#5407. * Reconstruct and allow VisBuilder to be rendered from DataExplorer * Follow proposal task 2 option 1 to migrate state management to DataExplorer Issue Resolve opensearch-project#5492 opensearch-project#5493 [2][VisBuilder Migration] Add context and implement side panel * add useVisBuilderContext * modify preloadedState in Data Explorer * implement side panel Issue Resolve: opensearch-project#5522 Signed-off-by: ananzh <ananzh@amazon.com> [3][VisBuilder Migration] Combine components into VisBuilderCanvas Signed-off-by: ananzh <ananzh@amazon.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
This PR avoids re-rendering the entire AppContainer when data services update. The re-render is caused by history object which is in AppMountParameters. This history object is part of the application's routing context and can change frequently as the url is updated by query, filter or time range. Each change in the history object could potentially trigger a re-render of the AppContainer and its child components. With this PR, the AppContainer will not be re-loaded. Instead each component, like Canvas and Panel, will be updated. Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Description
Add initial setup and migrate state management
This PR completes Task 1 and 2 in #5407.
Issue Resolve
#5492 #5493
Add context and implement side panel
Issue Resolve:
#5522
Combine components into VisBuilderCanvas
Issue Resolve:
#5523
Recording
[Recording 1]
record-1.mov
[Recording 2]
Line.graph.mov
[Recording 3]
migrate_state.mov
[Recording 4]
switch-idx.mov
Check List
yarn test:jest
yarn test:jest_integration