Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSCI] Create drilldown dashboard #5551

Conversation

thanhinhchtom
Copy link
Contributor

@thanhinhchtom thanhinhchtom commented Nov 29, 2023

Description

Create drilldown option in dashboard

Issues Resolved

Screenshot

image
image

Testing the changes

run yarn test:jest src/plugins/dashboard/public/application/actions/create_drilldown_action.test.tsx

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (f6ce6e7) 66.98% compared to head (ec153b1) 66.97%.
Report is 3 commits behind head on main.

Files Patch % Lines
...ic/application/actions/create_drilldown_action.tsx 60.00% 3 Missing and 5 partials ⚠️
src/plugins/dashboard/public/plugin.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5551      +/-   ##
==========================================
- Coverage   66.98%   66.97%   -0.01%     
==========================================
  Files        3293     3294       +1     
  Lines       63281    63304      +23     
  Branches    10061    10067       +6     
==========================================
+ Hits        42389    42401      +12     
- Misses      18451    18457       +6     
- Partials     2441     2446       +5     
Flag Coverage Δ
Linux_1 35.23% <4.34%> (-0.02%) ⬇️
Linux_2 55.21% <ø> (ø)
Linux_3 43.78% <52.17%> (+<0.01%) ⬆️
Linux_4 35.31% <4.34%> (-0.02%) ⬇️
Windows_1 35.25% <4.34%> (-0.02%) ⬇️
Windows_2 55.18% <ø> (ø)
Windows_3 43.80% <52.17%> (+<0.01%) ⬆️
Windows_4 35.31% <4.34%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Thanh Le <lechithanh2003@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant