[Fix] Remove empty suggestion history #5349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Willie Hung <willie880201044@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5349 +/- ##
=======================================
Coverage 66.96% 66.97%
=======================================
Files 3293 3293
Lines 63289 63291 +2
Branches 10065 10066 +1
=======================================
+ Hits 42383 42390 +7
+ Misses 18462 18459 -3
+ Partials 2444 2442 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Willie Hung <willie880201044@gmail.com>
willie-hung
commented
Oct 23, 2023
Signed-off-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Willie Hung <willie880201044@gmail.com>
Signed-off-by: Willie Hung <willie880201044@gmail.com>
willie-hung
commented
Nov 20, 2023
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
approved these changes
Dec 13, 2023
joshuarrrr
approved these changes
Dec 13, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 13, 2023
* Add search input filter Signed-off-by: Willie Hung <willie880201044@gmail.com> * Add CHANGELOG.md Signed-off-by: Willie Hung <willie880201044@gmail.com> * Add tests for empty suggestions Signed-off-by: Willie Hung <willie880201044@gmail.com> * Add code comment Signed-off-by: Willie Hung <willie880201044@gmail.com> --------- Signed-off-by: Willie Hung <willie880201044@gmail.com> Signed-off-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> (cherry picked from commit 808591a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
ananzh
pushed a commit
that referenced
this pull request
Dec 14, 2023
* Add search input filter * Add CHANGELOG.md * Add tests for empty suggestions * Add code comment --------- Signed-off-by: Willie Hung <willie880201044@gmail.com> Signed-off-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> (cherry picked from commit 808591a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove empty suggestion history to maintain a clean and relevant search experience.
Issues Resolved
Fixes #5348
Screenshot
Before
After
Check List
yarn test:jestyarn test:jest_integration