Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual][Backport 2.x]Migrate from legacy elasticsearch client to opensearch-js client in osd-opensearch-archiver package #4512

Conversation

manasvinibs
Copy link
Member

@manasvinibs manasvinibs commented Jul 6, 2023

Description

Manual Backport a44b09f from #4142.

In 2.x branch we are currently using opensearch-js client of v1.1.0 unlike main with v2.2.0 and hence updated osd-opensearch-archiver package to match other packages and refactored from legacy elastic search client to opensearch-js client v1.1.0.

…nsearch-js client in `osd-opensearch-archiver` package (opensearch-project#4142)

Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
Signed-off-by: Josh Romero <rmerqg@amazon.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #4512 (126264d) into 2.x (401e383) will decrease coverage by 0.01%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##              2.x    #4512      +/-   ##
==========================================
- Coverage   66.40%   66.40%   -0.01%     
==========================================
  Files        3245     3245              
  Lines       62449    62451       +2     
  Branches     9711     9712       +1     
==========================================
  Hits        41470    41470              
- Misses      18623    18624       +1     
- Partials     2356     2357       +1     
Flag Coverage Δ
Linux 66.35% <60.00%> (+<0.01%) ⬆️
Windows 66.34% <60.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...osd-opensearch-archiver/src/lib/docs/test_stubs.ts 68.75% <ø> (ø)
...ch-archiver/src/lib/indices/create_index_stream.ts 69.76% <ø> (ø)
...ch-archiver/src/lib/indices/delete_index_stream.ts 50.00% <ø> (ø)
...ver/src/lib/indices/opensearch_dashboards_index.ts 0.00% <0.00%> (ø)
...pensearch-archiver/src/lib/indices/delete_index.ts 36.36% <50.00%> (ø)
...r/src/lib/indices/generate_index_records_stream.ts 72.72% <50.00%> (-7.28%) ⬇️
...chiver/src/lib/docs/generate_doc_records_stream.ts 90.00% <100.00%> (ø)
...-archiver/src/lib/docs/index_doc_records_stream.ts 90.00% <100.00%> (ø)
...-opensearch-archiver/src/lib/indices/test_stubs.ts 80.00% <100.00%> (ø)

@manasvinibs manasvinibs merged commit 1e72f59 into opensearch-project:2.x Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants