-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Console] Convert lib/mappings to TypeScript #4008
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
f5faee9
Convert mappings.js to TypeScript
curq a7e1367
Convert mappings.test.js to TypeScript
curq 9b16a0a
Update CHANGELOG.md
curq 51f2d9f
Merge branch 'main' into console-mappings-ts
kavilla 204491c
Merge branch 'main' into console-mappings-ts
abbyhu2000 010629f
Merge branch 'main' into console-mappings-ts
curq 253aa8c
Add test for getTypes with multi-index mode
curq 617e02e
Merge branch 'main' into console-mappings-ts
curq 894fdea
Merge branch 'console-mappings-ts' of github.com:curq/OpenSearch-Dash…
curq 4251173
Merge branch 'opensearch-project:main' into console-mappings-ts
curq 499ac53
type update
curq 0d6ab00
Merge branch 'main' into console-mappings-ts
ashwin-pc a77d615
Merge branch 'main' into console-mappings-ts
curq 8daf1bc
update typing
curq df73ecc
Merge branch 'main' into console-mappings-ts
ananzh f4b9de8
Merge branch 'opensearch-project:main' into console-mappings-ts
curq a854556
CHANGELOG fix
curq 3571a7d
Changelog update
curq d8c81ba
Merge branch 'main' into console-mappings-ts
joshuarrrr 0ea3fdb
Merge branch 'main' into console-mappings-ts
joshuarrrr fc52bb3
Update Changelog
curq ccdee60
Merge branch 'main' into console-mappings-ts
ananzh e776e9b
Merge branch 'main' into console-mappings-ts
ananzh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I think there are also some missing tests on other functions like
retrieveAutoCompleteInfo
. Not sure if you could help to add some unit tests here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to add unit tests, but after looking through it,
retrieveAutoCompleteInfo
and otherretrieve
functions do api calls to running opensearch server, so I'm not sure if we can test it in unit tests. I think this one should be handled by functional tests