Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed KUI usage in maps_legacy plugin #3998

Merged
merged 16 commits into from
Jul 19, 2023
Merged

Removed KUI usage in maps_legacy plugin #3998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
f0b8d7e
Removed KUI usage from map_legacy plugin
miamia1999 May 8, 2023
0fbde16
Removed KUI icon from maps_legacy plugin
miamia1999 May 8, 2023
6e2569c
Merge branch 'main' into maps
abbyhu2000 May 16, 2023
33a17c9
import
miamia1999 May 30, 2023
93c46c7
Added to CHNAGELOG.md
miamia1999 Jun 20, 2023
34ae7c9
Updated CHANGELOG.md
miamia1999 Jun 20, 2023
25eee54
Update in CHANGELOG.md
miamia1999 Jun 20, 2023
977906e
Merge branch 'main' into maps
ananzh Jun 21, 2023
0bd7658
Upgrade the backport workflow (#4343)
AMoo-Miki Jun 21, 2023
48f15fd
Hide any output from `use_node` checking for Node compatibility (#4237)
AMoo-Miki Jun 21, 2023
ce79624
Resolved merge conflicts
miamia1999 Jun 22, 2023
0929f8b
Merge branch 'main' into maps
ananzh Jun 22, 2023
fc12e29
Apply suggestions from code review
joshuarrrr Jun 22, 2023
3d43c72
Merge branch 'main' into maps
joshuarrrr Jun 22, 2023
e996a15
Merge branch 'main' into maps
joshuarrrr Jun 26, 2023
a07dc58
Merge branch 'main' into maps
joshuarrrr Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- [Table Visualization] Remove custom styling for text-align:center in favor of OUI utility class. ([#4164](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4164))
- Migrate from legacy elasticsearch client to opensearch-js client in `osd-opensearch-archiver` package([#4142](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4142))
- Replace the use of `bluebird` in `saved_objects` plugin ([#4026](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4026))
- [Maps Legacy] Removed KUI usage in `maps_legacy` plugin([#3998](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3998))
- Relocate tutorials imagery into `src/plugins/home/public/assets/tutorials/logos` ([#4382](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4382))
- [VisBuilder] Use OUI icon ([#4446](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4446))
- [Vis Colors] [Region Maps] Replace hardcode color to OUI color in `region_map` plugin ([#4299](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4299))
Expand Down
9 changes: 9 additions & 0 deletions src/plugins/maps_legacy/public/map/_legend.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,12 @@
left: $euiSizeXXL;
white-space: nowrap;
}

.mapButton {
display: inline-block;
font: normal normal normal 14px/1 FontAwesome, sans-serif;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AMoo-Miki - for a follow-up PR, is there a way we can reference a particular OUI icon directly via SASS/CSS for a case like this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This piece of code is not written the React way else they could have just used OuiIcon. There is no direct access to the imagery.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I figured. I'm not sure we'd even want to expose direct access to the assets as part of OUI.

font-size: inherit;
text-rendering: auto;
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
}
2 changes: 1 addition & 1 deletion src/plugins/maps_legacy/public/map/opensearch_dashboards_map.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ function makeFitControl(fitContainer, opensearchDashboardsMap) {
);
$(this._fitContainer)
.html(
`<a class="kuiIcon fa-crop" href="#" title="${fitDatBoundsLabel}" aria-label="${fitDatBoundsLabel}"></a>`
`<a class="mapButton fa-crop" href="#" title="${fitDatBoundsLabel}" aria-label="${fitDatBoundsLabel}"></a>`
)
.on('click', (e) => {
e.preventDefault();
Expand Down