Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add json worker to monaco editor #3615

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 725a2a1 from #3424.

* feat: add json worker and language implement in dashboards

Signed-off-by: suzhou <suzhou@amazon.com>

---------

Signed-off-by: suzhou <suzhou@amazon.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 725a2a1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner March 16, 2023 02:23
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2023

Codecov Report

Merging #3615 (b00c657) into 2.x (8bfc631) will increase coverage by 0.06%.
The diff coverage is 72.72%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              2.x    #3615      +/-   ##
==========================================
+ Coverage   66.41%   66.48%   +0.06%     
==========================================
  Files        3206     3209       +3     
  Lines       61597    61615      +18     
  Branches     9503     9504       +1     
==========================================
+ Hits        40911    40962      +51     
+ Misses      18408    18382      -26     
+ Partials     2278     2271       -7     
Flag Coverage Δ
Linux 66.42% <72.72%> (+<0.01%) ⬆️
Windows 66.42% <72.72%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/osd-monaco/src/monaco_environment.ts 33.33% <33.33%> (ø)
packages/osd-monaco/src/worker_store.ts 75.00% <75.00%> (ø)
packages/osd-monaco/src/index.ts 100.00% <100.00%> (ø)
packages/osd-monaco/src/json/index.ts 100.00% <100.00%> (ø)
packages/osd-monaco/src/xjson/language.ts 51.42% <100.00%> (+5.48%) ⬆️

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Josh Romero <rmerqg@amazon.com>
@abbyhu2000 abbyhu2000 merged commit 67de375 into 2.x Mar 22, 2023
@github-actions github-actions bot deleted the backport/backport-3424-to-2.x branch March 22, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants