[Backport 2.x] [Vis Builder] Add metric to metric, bucket to bucket aggregation persistence #3594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istence (#3495) * Add metric to metric, bucket to bucket aggregation persistance Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Add logics to avoid exceeding the max count for each schema field Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Add changelog entry Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * addressing comments Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Add unit tests for functions in use_persisted_agg_params Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * rewrite unit tests to test the entire functionality Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> (cherry picked from commit 525b033) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #3594 +/- ##
==========================================
+ Coverage 66.45% 66.46% +0.01%
==========================================
Files 3205 3206 +1
Lines 61563 61597 +34
Branches 9497 9503 +6
==========================================
+ Hits 40911 40943 +32
- Misses 18380 18382 +2
Partials 2272 2272
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
whitesource failure for |
joshuarrrr
approved these changes
Mar 11, 2023
abbyhu2000
approved these changes
Mar 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 525b033 from #3495.