Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix bug that prevents selected join field to be used #3226

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 8c6f569 from #3213.

Remove setting join field even if it is already set.

Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>

Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
(cherry picked from commit 8c6f569)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner January 9, 2023 22:18
@manasvinibs manasvinibs added v2.5.0 'Issues and PRs related to version v2.5.0' autocut Skip the changelog verification check on backports labels Jan 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2023

Codecov Report

Merging #3226 (9b1510e) into 2.x (c485e9b) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              2.x    #3226      +/-   ##
==========================================
- Coverage   66.56%   66.50%   -0.07%     
==========================================
  Files        3200     3200              
  Lines       61287    61287              
  Branches     9439     9439              
==========================================
- Hits        40794    40756      -38     
- Misses      18238    18269      +31     
- Partials     2255     2262       +7     
Flag Coverage Δ
Linux 66.50% <ø> (-0.01%) ⬇️
Windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/dev/build/lib/get_build_number.ts 57.14% <0.00%> (-42.86%) ⬇️
src/setup_node_env/harden/child_process.js 38.46% <0.00%> (-38.47%) ⬇️
packages/osd-cross-platform/src/path.ts 51.21% <0.00%> (-34.15%) ⬇️
...ges/osd-apm-config-loader/src/config.test.mocks.ts 91.30% <0.00%> (-8.70%) ⬇️
src/dev/build/lib/config.ts 79.41% <0.00%> (-5.89%) ⬇️
...s/osd-optimizer/src/node/node_auto_tranpilation.ts 83.67% <0.00%> (-4.09%) ⬇️
packages/osd-optimizer/src/node/cache.ts 50.00% <0.00%> (-3.95%) ⬇️
...ic/application/models/sense_editor/sense_editor.ts 64.00% <0.00%> (-0.89%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@manasvinibs manasvinibs merged commit efc979c into 2.x Jan 10, 2023
@github-actions github-actions bot deleted the backport/backport-3213-to-2.x branch January 10, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants