Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add json worker and language implement in dashboards #3121

Closed
wants to merge 2 commits into from

Conversation

SuZhou-Joe
Copy link
Member

Signed-off-by: suzhou suzhou@amazon.com

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: suzhou <suzhou@amazon.com>
@SuZhou-Joe SuZhou-Joe requested a review from a team as a code owner December 22, 2022 13:26
Signed-off-by: suzhou <suzhou@amazon.com>
Copy link
Collaborator

@AMoo-Miki AMoo-Miki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this is not raised on main?

@SuZhou-Joe
Copy link
Member Author

Any reason this is not raised on main?

Good point. I thought we can merge to 2.x and add a backport main label to merge to main. But anyway I will raise a issue to discuss the reason why we introduce the new json language support first.

@joshuarrrr
Copy link
Member

Yeah, @SuZhou-Joe all PRs should be raised against main first, and then we'll backport as necessary from there: https://github.com/opensearch-project/.github/blob/main/RELEASING.md#branching

But thanks for opening the issue first, that will provide helpful context.

@joshuarrrr joshuarrrr marked this pull request as draft December 23, 2022 01:13
@SuZhou-Joe SuZhou-Joe changed the base branch from 2.x to main December 23, 2022 01:15
@SuZhou-Joe SuZhou-Joe changed the base branch from main to 2.x December 23, 2022 01:16
@SuZhou-Joe
Copy link
Member Author

#3133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants