-
Notifications
You must be signed in to change notification settings - Fork 936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MD] new UX changes for password fields and update password modal in data source management #2532
[MD] new UX changes for password fields and update password modal in data source management #2532
Conversation
…source management Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>
Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2532 +/- ##
=======================================
Coverage 66.74% 66.74%
=======================================
Files 3201 3201
Lines 60948 60951 +3
Branches 9267 9267
=======================================
+ Hits 40679 40682 +3
Misses 18052 18052
Partials 2217 2217
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
defaultMessage: 'Updated password', | ||
} | ||
); | ||
export const CONFIRM_NEW_PASSWORD_TEXT = i18n.translate( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ive called this out in some of the other MD PR's, but lets move the translate functions into the react components. That way we have realtime translations instead of static translations that only run during compile time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, I will resolve it today in a different PR as many PRs will have conflicts if I do it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mpabba3003!
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2532-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9f6bfc01d94e4100e790857985bf2e1b648160af
# Push it to GitHub
git push --set-upstream origin backport/backport-2532-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2532-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9f6bfc01d94e4100e790857985bf2e1b648160af
# Push it to GitHub
git push --set-upstream origin backport/backport-2532-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
…data source management (#2532) * nex ux changes for password fields and update password modal in data source management Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * update change log Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> (cherry picked from commit 9f6bfc0)
…data source management (#2532) (#2553) * nex ux changes for password fields and update password modal in data source management Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * update change log Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> (cherry picked from commit 9f6bfc0) Co-authored-by: Manideep Pabba <109986843+mpabba3003@users.noreply.github.com>
…data source management (opensearch-project#2532) (opensearch-project#2553) * nex ux changes for password fields and update password modal in data source management Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * update change log Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> (cherry picked from commit 9f6bfc0) Co-authored-by: Manideep Pabba <109986843+mpabba3003@users.noreply.github.com>
…data source management (opensearch-project#2532) * nex ux changes for password fields and update password modal in data source management Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * update change log Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
Signed-off-by: mpabba3003 amazonmanideep@gmail.com
Description
new UX changes for password fields and update password modal in data source management
Issues Resolved
[List any issues this PR will resolve]
opensearch-project/ux#34
SCREENSHOTS
Data.Sources.-.OpenSearch.Dashboards.1.mp4
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr