[D&D] Adds count field to field picker #2231
Conversation
Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>
There was a problem hiding this comment.
I like that most of the special case handling is confined to the use_dropbox hook, and I think this is a good start for now. But it reads as one-off handling of a special case. That may actually be the correct model for how to handle it, but it just makes me wonder if some of the other generalized assumptions about fields (and even some of the naming) is a bit too narrow to comfortably accommodate this more primitive field. No additional suggestions, just something we'll want to keep an eye on if we find ourselves adding more exceptions in the future.
|
|
||
| export interface EmptyDragDataType { | ||
| namespace: null; | ||
| value: null; | ||
| } | ||
| export interface FieldDragDataType { | ||
| namespace: 'field-data'; | ||
| value: Pick<IndexPatternField, 'name' | 'displayName' | 'type'> | null; | ||
| value: IndexPatternField['name'] | null | typeof COUNT_FIELD; |
There was a problem hiding this comment.
nit - I can't particularly justify why, but I think it reads nicer if null is last in the union.
There was a problem hiding this comment.
Will update it in a follow-up PR
|
One other question - because |
|
@joshuarrrr I agree. I was tempted to add another prop to identify the count field since there are many ways to slice and dice this. But I went with this approach since it was cleaner and didn't need a lot of overhead. If we need to add any more exceptions, I will refactor to be more generic in the way we handle them. As for count applying to any index pattern, it's not clear which schemas support it though. So to persist it in a new schema will need a lil thought. I want to work on persisting aggs when vis types change as a separate problem and solve for it in a generic way |
Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> (cherry picked from commit aaa35c3)
Signed-off-by: Ashwin Pc ashwinpc@amazon.com
Description
Adds a
Countfield to the field picker in WizardIssues Resolved
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr