Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [Data Explorer] share link of saved search does not work properly #5323

Closed
abbyhu2000 opened this issue Oct 18, 2023 · 1 comment · Fixed by #5324
Closed

[BUG] [Data Explorer] share link of saved search does not work properly #5323

abbyhu2000 opened this issue Oct 18, 2023 · 1 comment · Fixed by #5324
Labels
bug Something isn't working data explorer Issues related to the Data Explorer project de-angular de-angularize work

Comments

@abbyhu2000
Copy link
Member

abbyhu2000 commented Oct 18, 2023 •
edited
Loading

Describe the bug
The shared link of saved search does not work properly. The URL does not include filters and other params. After i paste the URL into browser, there is error showing Error restoring state from URL, Cannot read properties of null (reading 'length').

To Reproduce

Screen.Recording.2023-10-18.at.3.10.46.PM.mov
@abbyhu2000 abbyhu2000 added bug Something isn't working untriaged de-angular de-angularize work data explorer Issues related to the Data Explorer project labels Oct 18, 2023
@abbyhu2000 abbyhu2000 mentioned this issue Oct 18, 2023
Closed
@abbyhu2000
Copy link
Member Author

The error is caused by default global param 'g' is not appended to the URL when we initially saved a saved search. Thus when we generate the shared link, it is unable to find and process the 'g' part of the URL.

@abbyhu2000 abbyhu2000 mentioned this issue Oct 18, 2023
Merged
7 tasks
kavilla pushed a commit that referenced this issue Oct 23, 2023
@opensearch-trigger-bot @github-actions @abbyhu2000
fix share link in discover (#5324) (#5330)
3512117 
Fixes:
#5323

(cherry picked from commit e1db842)

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working data explorer Issues related to the Data Explorer project de-angular de-angularize work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Data Explorer] Fix share link of save search abbyhu2000/OpenSearch-Dashboards
1 participant
@abbyhu2000