Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Non-Inclusive Lanuage] Replace references to master branch with main #1691

Closed
tmarkley opened this issue Jun 7, 2022 · 3 comments · Fixed by #1780
Closed

[Non-Inclusive Lanuage] Replace references to master branch with main #1691

tmarkley opened this issue Jun 7, 2022 · 3 comments · Fixed by #1780
Assignees
@kaddy645
Labels
non-inclusive language v2.1.0

Comments

@tmarkley
Copy link
Contributor

tmarkley commented Jun 7, 2022

Parent: #1318

Instances of incorrect master branch references

OpenSearch-Dashboards/examples/bfetch_explorer/public/plugin.tsx

Line 78 in 1caf907

'https://github.com/opensearch-project/OpenSearch-Dashboards/blob/master/src/plugins/bfetch/README.md',

OpenSearch-Dashboards/examples/developer_examples/README.md

Line 17 in 1caf907

href: 'https://github.com/opensearch-project/OpenSearch-Dashboards/tree/master/src/plugins/foo/README.md',

OpenSearch-Dashboards/examples/embeddable_explorer/public/plugin.tsx

Line 89 in 1caf907

'https://github.com/opensearch-project/OpenSearch-Dashboards/tree/master/src/plugins/embeddable/README.md',

OpenSearch-Dashboards/examples/routing_example/public/app.tsx

Lines 70 to 93 in 1caf907

{
label: 'IRouter API docs',
href:
'https://github.com/opensearch-project/OpenSearch-Dashboards/blob/master/docs/development/core/server/opensearch-dashboards-plugin-core-server.irouter.md',
iconType: 'logoGithub',
target: '_blank',
size: 's',
},
{
label: 'HttpHandler (core.http.fetch) API docs',
href:
'https://github.com/opensearch-project/OpenSearch-Dashboards/blob/master/docs/development/core/public/opensearch-dashboards-plugin-core-public.httphandler.md',
iconType: 'logoGithub',
target: '_blank',
size: 's',
},
{
label: 'Conventions',
href:
'https://github.com/opensearch-project/OpenSearch-Dashboards/tree/master/DEVELOPER_GUIDE.md#api-endpoints',
iconType: 'logoGithub',
target: '_blank',
size: 's',
},

OpenSearch-Dashboards/examples/routing_example/public/plugin.tsx

Lines 64 to 79 in 1caf907

{
label: 'IRouter',
href:
'https://github.com/opensearch-project/OpenSearch-Dashboards/blob/master/docs/development/core/server/opensearch-dashboards-plugin-core-server.irouter.md',
iconType: 'logoGithub',
target: '_blank',
size: 's',
},
{
label: 'HttpHandler (core.http.fetch)',
href:
'https://github.com/opensearch-project/OpenSearch-Dashboards/blob/master/docs/development/core/public/opensearch-dashboards-plugin-core-public.httphandler.md',
iconType: 'logoGithub',
target: '_blank',
size: 's',
},

OpenSearch-Dashboards/examples/search_examples/README.md

Line 9 in 1caf907

See the [opensearchDashboards contributing guide](https://github.com/opensearch-project/OpenSearch-Dashboards/blob/master/CONTRIBUTING.md) for instructions setting up your development environment.

OpenSearch-Dashboards/examples/state_containers_examples/public/plugin.ts

Lines 83 to 137 in 1caf907

developerExamples.register({
appId: 'stateContainersExampleBrowserHistory',
title: 'State containers using browser history',
description: `An example todo app that uses browser history and state container utilities like createStateContainerReactHelpers,
createStateContainer, createOsdUrlStateStorage, createSessionStorageStateStorage,
syncStates and getStateFromOsdUrl to keep state in sync with the URL. Change some parameters, navigate away and then back, and the
state should be preserved.`,
links: [
{
label: 'README',
href:
'https://github.com/opensearch-project/OpenSearch-Dashboards/tree/master/src/plugins/opensearch_dashboards_utils/docs/state_containers/README.md',
iconType: 'logoGithub',
size: 's',
target: '_blank',
},
],
});
developerExamples.register({
appId: 'stateContainersExampleHashHistory',
title: 'State containers using hash history',
description: `An example todo app that uses hash history and state container utilities like createStateContainerReactHelpers,
createStateContainer, createOsdUrlStateStorage, createSessionStorageStateStorage,
syncStates and getStateFromOsdUrl to keep state in sync with the URL. Change some parameters, navigate away and then back, and the
state should be preserved.`,
links: [
{
label: 'README',
href:
'https://github.com/opensearch-project/OpenSearch-Dashboards/tree/master/src/plugins/opensearch_dashboards_utils/docs/state_containers/README.md',
iconType: 'logoGithub',
size: 's',
target: '_blank',
},
],
});
developerExamples.register({
appId: PLUGIN_ID,
title: 'Sync state from a query bar with the url',
description: `Shows how to use data.syncQueryStateWitUrl in combination with state container utilities from opensearch_dashboards_utils to
show a query bar that stores state in the url and is kept in sync.
`,
links: [
{
label: 'README',
href:
'https://github.com/opensearch-project/OpenSearch-Dashboards/blob/master/src/plugins/data/public/query/state_sync/README.md',
iconType: 'logoGithub',
size: 's',
target: '_blank',
},
],
});

OpenSearch-Dashboards/examples/ui_actions_explorer/public/plugin.tsx

Line 137 in 1caf907

'https://github.com/opensearch-project/OpenSearch-Dashboards/blob/master/src/plugins/ui_actions/README.md',

OpenSearch-Dashboards/examples/url_generators_explorer/public/plugin.tsx

Line 73 in 1caf907

'https://github.com/opensearch-project/OpenSearch-Dashboards/blob/master/src/plugins/share/public/url_generators/README.md',

OpenSearch-Dashboards/packages/opensearch-eslint-config-opensearch-dashboards/typescript.js

Line 100 in 1caf907

// https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/ROADMAP.md

OpenSearch-Dashboards/packages/osd-config/src/config_service.test.ts

Line 45 in 1caf907

branch: 'master',

OpenSearch-Dashboards/packages/osd-config/src/env.test.ts

Line 39 in 1caf907

branch: 'master',

OpenSearch-Dashboards/packages/osd-eslint-import-resolver-opensearch-dashboards/import_resolver_opensearch_dashboards.js

Line 124 in 1caf907

// use version 2 of the resolver interface, https://github.com/benmosher/eslint-plugin-import/blob/master/resolvers/README.md#interfaceversion--number

OpenSearch-Dashboards/packages/osd-eslint-import-resolver-opensearch-dashboards/package.json

Line 13 in 1caf907

"url": "https://github.com/opensearch-project/OpenSearch-Dashboards/tree/master/packages/osd-eslint-import-resolver-opensearch-dashboards"

OpenSearch-Dashboards/packages/osd-eslint-import-resolver-opensearch-dashboards/README.md

Line 63 in 1caf907

See [the resolvers docs](https://github.com/benmosher/eslint-plugin-import#resolvers) or the [resolver spec](https://github.com/benmosher/eslint-plugin-import/blob/master/resolvers/README.md#resolvesource-file-config---found-boolean-path-string-) for more details.

OpenSearch-Dashboards/packages/osd-i18n/README.md

Lines 125 to 149 in 1caf907

[Here](https://github.com/yahoo/intl-messageformat/blob/master/src/core.js#L62)
you can find default format options used as the prototype of the formats
provided to the constructor.
Creating instances of `IntlMessageFormat` is expensive.
[Intl-format-cache](https://github.com/yahoo/intl-format-cache)
library is simply to make it easier to create a cache of format
instances of a particular type to aid in their reuse. Under the
hood, this package creates a cache key based on the arguments passed
to the memoized constructor.
```js
import memoizeIntlConstructor from 'intl-format-cache';
const getMessageFormat = memoizeIntlConstructor(IntlMessageFormat);
```
## Vanilla JS
`Intl-messageformat` package assumes that the
[Intl](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl)
global object exists in the runtime. `Intl` is present in all modern
browsers and Node.js 0.10+. In order to load i18n engine
in Node.js we should simply `import` this module (in Node.js, the
[data](https://github.com/yahoo/intl-messageformat/tree/master/dist/locale-data)

OpenSearch-Dashboards/packages/osd-i18n/src/core/i18n.ts

Line 147 in 1caf907

* {@link https://github.com/yahoo/intl-messageformat/blob/master/src/core.js#L62}

OpenSearch-Dashboards/packages/osd-plugin-generator/README.md

Lines 15 to 44 in 1caf907

To target the current development version of OpenSearch Dashboards just use the default `master` branch.
```sh
node scripts/generate_plugin --name my_plugin_name -y
# generates a plugin in `plugins/my_plugin_name`
```
To target 1.0, use the `1.0` branch.
```sh
git checkout 1.x
yarn osd bootstrap # always bootstrap when switching branches
node scripts/generate_plugin --name my_plugin_name -y
# generates a plugin for OpenSearch Dashboards 1.0 in `../opensearch-dashboards-extra/my_plugin_name`
```
The generate script supports a few flags; run it with the `--help` flag to learn more.
```sh
node scripts/generate_plugin --help
```
## Updating
Since the Plugin Generator is now a part of the OpenSearch Dashboards repo, when you update your local checkout of the OpenSearch Dashboards repository and `bootstrap` everything should be up to date!
> ***NOTE:*** These commands should be run from the OpenSearch Dashboards repo, and `upstream` is our convention for the git remote that references https://github.com/opensearch-project/OpenSearch-Dashboards.git, unless you added this remote you might need to use `origin`.
```sh
git pull upstream master

OpenSearch-Dashboards/packages/osd-plugin-generator/template/README.md.ejs

Line 10 in 1caf907

guide](https://github.com/opensearch-project/OpenSearch-Dashboards/blob/master/CONTRIBUTING.md) for instructions

OpenSearch-Dashboards/packages/osd-pm/src/utils/projects.ts

Line 109 in 1caf907

// https://github.com/isaacs/node-glob/blob/master/common.js#L104

OpenSearch-Dashboards/packages/osd-spec-to-console/README.md

Lines 1 to 16 in 1caf907

\ mini utility to convert [OpenSearch's REST spec](https://github.com/opensearch-project/OpenSearch/blob/master/rest-api-spec) to Console's (OpenSearch Dashboards) autocomplete format.
It is used to semi-manually update Console's autocompletion rules.
### Retrieving the spec
If you don't have a copy of the OpenSearch repo on your machine, follow these steps to clone only the rest API specs
```
mkdir opensearch-spec && cd opensearch-spec
git init
git remote add origin https://github.com/opensearch-project/OpenSearch
git config core.sparsecheckout true
echo "rest-api-spec/src/main/resources/rest-api-spec/api/*\nx-pack/plugin/src/test/resources/rest-api-spec/api/*" > .git/info/sparse-checkout
git pull --depth=1 origin master

OpenSearch-Dashboards/packages/osd-spec-to-console/lib/convert.js

Line 40 in 1caf907

* Since https://github.com/elastic/elasticsearch/pull/42346 has been merged into ES master

OpenSearch-Dashboards/packages/osd-test/src/failed_tests_reporter/add_messages_to_report.test.ts

Lines 105 to 251 in 1caf907

at /var/lib/jenkins/workspace/elastic+kibana+master/JOB/x-pack-ciGroup7/node/immutable/kibana/node_modules/selenium-webdriver/lib/webdriver.js:834:17
at process._tickCallback (internal/process/next_tick.js:68:7)
at lastError (/var/lib/jenkins/workspace/elastic+kibana+master/JOB/x-pack-ciGroup7/node/immutable/kibana/test/common/services/retry/retry_for_success.ts:28:9)
- at onFailure (/var/lib/jenkins/workspace/elastic+kibana+master/JOB/x-pack-ciGroup7/node/immutable/kibana/test/common/services/retry/retry_for_success.ts:68:13)]]›
+ at onFailure (/var/lib/jenkins/workspace/elastic+kibana+master/JOB/x-pack-ciGroup7/node/immutable/kibana/test/common/services/retry/retry_for_success.ts:68:13)
‹/failure›
‹/testcase›
‹testcase name="maps app "after all" hook" classname="Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/maps" time="0.179" metadata-json="{"messages":["foo"],"screenshots":[{"name":"failure[dashboard app using current data dashboard snapshots compare TSVB snapshot]","url":"https://storage.googleapis.com/kibana-ci-artifacts/jobs/elastic+kibana+7.x/1632/kibana-oss-tests/test/functional/screenshots/failure/dashboard%20app%20using%20current%20data%20dashboard%20snapshots%20compare%20TSVB%20snapshot.png"}]}"›
‹system-out›
- ‹![CDATA[[00:00:00] │
+ [00:00:00] │
[00:07:04] └-: maps app
...
-]]›
+
‹/system-out›
‹failure›
- ‹![CDATA[{ NoSuchSessionError: This driver instance does not have a valid session ID (did you call WebDriver.quit()?) and may no longer be used.
+ { NoSuchSessionError: This driver instance does not have a valid session ID (did you call WebDriver.quit()?) and may no longer be used.
at promise.finally (/var/lib/jenkins/workspace/elastic+kibana+master/JOB/x-pack-ciGroup7/node/immutable/kibana/node_modules/selenium-webdriver/lib/webdriver.js:726:38)
at Object.thenFinally [as finally] (/var/lib/jenkins/workspace/elastic+kibana+master/JOB/x-pack-ciGroup7/node/immutable/kibana/node_modules/selenium-webdriver/lib/promise.js:124:12)
- at process._tickCallback (internal/process/next_tick.js:68:7) name: 'NoSuchSessionError', remoteStacktrace: '' }]]›
+ at process._tickCallback (internal/process/next_tick.js:68:7) name: 'NoSuchSessionError', remoteStacktrace: '' }
‹/failure›
‹/testcase›
‹testcase name="InfraOps app feature controls infrastructure security global infrastructure all privileges shows infrastructure navlink" classname="Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/infra/feature_controls/infrastructure_security·ts"›
‹system-out›
- ‹![CDATA[[00:00:00] │
+ [00:00:00] │
[00:05:13] └-: InfraOps app
...
-]]›
+
‹/system-out›
‹skipped/›
‹/testcase›
‹testcase name="machine learning anomaly detection saved search with lucene query job creation opens the advanced section" classname="Firefox XPack UI Functional Tests.x-pack/test/functional/apps/machine_learning/anomaly_detection/saved_search_job·ts" time="6.040"›
- ‹system-out›‹![CDATA[[00:21:57] └-: machine learning...]]›‹/system-out›
- ‹failure›‹![CDATA[{ NoSuchSessionError: Tried to run command without establishing a connection
+ ‹system-out›[00:21:57] └-: machine learning...‹/system-out›
+ ‹failure›{ NoSuchSessionError: Tried to run command without establishing a connection
at Object.throwDecodedError (/dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/error.js:550:15)
at parseHttpResponse (/dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/http.js:563:13)
at Executor.execute (/dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/http.js:489:26)
- at process._tickCallback (internal/process/next_tick.js:68:7) name: 'NoSuchSessionError', remoteStacktrace: '' }]]›‹/failure›
+ at process._tickCallback (internal/process/next_tick.js:68:7) name: 'NoSuchSessionError', remoteStacktrace: '' }‹/failure›
‹/testcase›
‹/testsuite›
-‹/testsuites›
+‹/testsuites›
\\ No newline at end of file
`);
});
it('rewrites jest reports with minimal changes', async () => {
const xml = await addMessagesToReport({
report: await parseTestReport(JEST_REPORT),
messages: [
{
classname: 'X-Pack Jest Tests.x-pack/legacy/plugins/code/server/lsp',
name: 'launcher can reconnect if process died',
message: 'foo bar',
},
],
log,
reportPath: Path.resolve(__dirname, './__fixtures__/jest_report.xml'),
});
expect(createPatch('jest.xml', JEST_REPORT, xml, { context: 0 })).toMatchInlineSnapshot(`
Index: jest.xml
===================================================================
--- jest.xml [object Object]
+++ jest.xml
@@ -3,13 +3,17 @@
‹testsuite name="x-pack/legacy/plugins/code/server/lsp/abstract_launcher.test.ts" timestamp="2019-06-07T03:42:21" time="14.504" tests="5" failures="1" skipped="0" file="/var/lib/jenkins/workspace/elastic+kibana+master/JOB/x-pack-intake/node/immutable/kibana/x-pack/legacy/plugins/code/server/lsp/abstract_launcher.test.ts"›
‹testcase classname="X-Pack Jest Tests.x-pack/legacy/plugins/code/server/lsp" name="launcher can start and end a process" time="1.316"/›
‹testcase classname="X-Pack Jest Tests.x-pack/legacy/plugins/code/server/lsp" name="launcher can force kill the process if langServer can not exit" time="3.182"/›
‹testcase classname="X-Pack Jest Tests.x-pack/legacy/plugins/code/server/lsp" name="launcher can reconnect if process died" time="7.060"›
- ‹failure›
- ‹![CDATA[TypeError: Cannot read property '0' of undefined
- at Object.‹anonymous›.test (/var/lib/jenkins/workspace/elastic+kibana+master/JOB/x-pack-intake/node/immutable/kibana/x-pack/legacy/plugins/code/server/lsp/abstract_launcher.test.ts:166:10)]]›
- ‹/failure›
+ ‹failure›‹![CDATA[
+ TypeError: Cannot read property '0' of undefined
+ at Object.‹anonymous›.test (/var/lib/jenkins/workspace/elastic+kibana+master/JOB/x-pack-intake/node/immutable/kibana/x-pack/legacy/plugins/code/server/lsp/abstract_launcher.test.ts:166:10)
+ ]]›‹/failure›
+ ‹system-out›Failed Tests Reporter:
+ - foo bar
+
+‹/system-out›
‹/testcase›
‹testcase classname="X-Pack Jest Tests.x-pack/legacy/plugins/code/server/lsp" name="passive launcher can start and end a process" time="0.435"/›
‹testcase classname="X-Pack Jest Tests.x-pack/legacy/plugins/code/server/lsp" name="passive launcher should restart a process if a process died before connected" time="1.502"/›
‹/testsuite›
-‹/testsuites›
+‹/testsuites›
\\ No newline at end of file
`);
});
it('rewrites mocha reports with minimal changes', async () => {
const xml = await addMessagesToReport({
report: await parseTestReport(MOCHA_REPORT),
messages: [
{
name: 'code in multiple nodes "before all" hook',
classname: 'X-Pack Mocha Tests.x-pack/legacy/plugins/code/server/__tests__/multi_node·ts',
message: 'foo bar',
},
],
log,
reportPath: Path.resolve(__dirname, './__fixtures__/mocha_report.xml'),
});
expect(createPatch('mocha.xml', MOCHA_REPORT, xml, { context: 0 })).toMatchInlineSnapshot(`
Index: mocha.xml
===================================================================
--- mocha.xml [object Object]
+++ mocha.xml
@@ -1,13 +1,16 @@
‹?xml version="1.0" encoding="utf-8"?›
‹testsuites›
‹testsuite timestamp="2019-06-13T23:29:36" time="30.739" tests="1444" failures="2" skipped="3"›
‹testcase name="code in multiple nodes "before all" hook" classname="X-Pack Mocha Tests.x-pack/legacy/plugins/code/server/__tests__/multi_node·ts" time="0.121"›
- ‹system-out›
- ‹![CDATA[]]›
+ ‹system-out›Failed Tests Reporter:
+ - foo bar
+
+
+
‹/system-out›
- ‹failure›
- ‹![CDATA[Error: Unable to read artifact info from https://artifacts-api.opensearch.org/v1/versions/8.0.0-SNAPSHOT/builds/latest/projects/elasticsearch: Service Temporarily Unavailable
+ ‹failure›‹![CDATA[
+ Error: Unable to read artifact info from https://artifacts-api.opensearch.org/v1/versions/8.0.0-SNAPSHOT/builds/latest/projects/elasticsearch: Service Temporarily Unavailable
‹html›
‹head›‹title›503 Service Temporarily Unavailable‹/title›‹/head›
‹body bgcolor="white"›
‹center›‹h1›503 Service Temporarily Unavailable‹/h1›‹/center›
@@ -15,24 +18,24 @@
‹/body›
‹/html›
at Function.getSnapshot (/var/lib/jenkins/workspace/elastic+kibana+master/JOB/x-pack-intake/node/immutable/kibana/packages/osd-opensearch/src/artifact.js:95:13)

OpenSearch-Dashboards/packages/osd-test/src/failed_tests_reporter/get_failures.test.ts

Lines 44 to 115 in 1caf907

at /var/lib/jenkins/workspace/elastic+kibana+master/JOB/x-pack-ciGroup7/node/immutable/kibana/node_modules/selenium-webdriver/lib/webdriver.js:834:17
at process._tickCallback (internal/process/next_tick.js:68:7)
at lastError (/var/lib/jenkins/workspace/elastic+kibana+master/JOB/x-pack-ciGroup7/node/immutable/kibana/test/common/services/retry/retry_for_success.ts:28:9)
at onFailure (/var/lib/jenkins/workspace/elastic+kibana+master/JOB/x-pack-ciGroup7/node/immutable/kibana/test/common/services/retry/retry_for_success.ts:68:13)
",
"likelyIrrelevant": false,
"name": "maps app maps loaded from sample data ecommerce \\"before all\\" hook",
"time": "154.378",
},
Object {
"classname": "Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/maps",
"failure": "
{ NoSuchSessionError: This driver instance does not have a valid session ID (did you call WebDriver.quit()?) and may no longer be used.
at promise.finally (/var/lib/jenkins/workspace/elastic+kibana+master/JOB/x-pack-ciGroup7/node/immutable/kibana/node_modules/selenium-webdriver/lib/webdriver.js:726:38)
at Object.thenFinally [as finally] (/var/lib/jenkins/workspace/elastic+kibana+master/JOB/x-pack-ciGroup7/node/immutable/kibana/node_modules/selenium-webdriver/lib/promise.js:124:12)
at process._tickCallback (internal/process/next_tick.js:68:7) name: 'NoSuchSessionError', remoteStacktrace: '' }
",
"likelyIrrelevant": true,
"metadata-json": "{\\"messages\\":[\\"foo\\"],\\"screenshots\\":[{\\"name\\":\\"failure[dashboard app using current data dashboard snapshots compare TSVB snapshot]\\",\\"url\\":\\"https://storage.googleapis.com/kibana-ci-artifacts/jobs/elastic+kibana+7.x/1632/kibana-oss-tests/test/functional/screenshots/failure/dashboard%20app%20using%20current%20data%20dashboard%20snapshots%20compare%20TSVB%20snapshot.png\\"}]}",
"name": "maps app \\"after all\\" hook",
"time": "0.179",
},
Object {
"classname": "Firefox XPack UI Functional Tests.x-pack/test/functional/apps/machine_learning/anomaly_detection/saved_search_job·ts",
"failure": "{ NoSuchSessionError: Tried to run command without establishing a connection
at Object.throwDecodedError (/dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/error.js:550:15)
at parseHttpResponse (/dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/http.js:563:13)
at Executor.execute (/dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/http.js:489:26)
at process._tickCallback (internal/process/next_tick.js:68:7) name: 'NoSuchSessionError', remoteStacktrace: '' }",
"likelyIrrelevant": true,
"name": "machine learning anomaly detection saved search with lucene query job creation opens the advanced section",
"time": "6.040",
},
]
`);
});
it('discovers failures in jest report', async () => {
const failures = getFailures(await parseTestReport(JEST_REPORT));
expect(failures).toMatchInlineSnapshot(`
Array [
Object {
"classname": "X-Pack Jest Tests.x-pack/legacy/plugins/code/server/lsp",
"failure": "
TypeError: Cannot read property '0' of undefined
at Object.<anonymous>.test (/var/lib/jenkins/workspace/elastic+kibana+master/JOB/x-pack-intake/node/immutable/kibana/x-pack/legacy/plugins/code/server/lsp/abstract_launcher.test.ts:166:10)
",
"likelyIrrelevant": false,
"name": "launcher can reconnect if process died",
"time": "7.060",
},
]
`);
});
it('discovers failures in mocha report', async () => {
const failures = getFailures(await parseTestReport(MOCHA_REPORT));
expect(failures).toMatchInlineSnapshot(`
Array [
Object {
"classname": "X-Pack Mocha Tests.x-pack/legacy/plugins/code/server/__tests__/multi_node·ts",
"failure": "
Error: Unable to read artifact info from https://artifacts-api.opensearch.org/v1/versions/8.0.0-SNAPSHOT/builds/latest/projects/elasticsearch: Service Temporarily Unavailable
<html>
<head><title>503 Service Temporarily Unavailable</title></head>
<body bgcolor=\\"white\\">
<center><h1>503 Service Temporarily Unavailable</h1></center>
<hr><center>nginx/1.13.7</center>
</body>
</html>
at Function.getSnapshot (/var/lib/jenkins/workspace/elastic+kibana+master/JOB/x-pack-intake/node/immutable/kibana/packages/osd-opensearch/src/artifact.js:95:13)

OpenSearch-Dashboards/packages/osd-test/src/failed_tests_reporter/run_failed_tests_reporter_cli.ts

Lines 68 to 70 in 1caf907

const isMasterOrVersion = branch === 'master' || branch.match(/^\d+\.(x|\d+)$/);
if (!isMasterOrVersion || isPr) {
log.info('Failure issues only created on master/version branch jobs');

OpenSearch-Dashboards/packages/osd-test/src/failed_tests_reporter/__fixtures__/ftr_report.xml

Lines 15 to 31 in 1caf907

at /var/lib/jenkins/workspace/elastic+kibana+master/JOB/x-pack-ciGroup7/node/immutable/kibana/node_modules/selenium-webdriver/lib/webdriver.js:834:17
at process._tickCallback (internal/process/next_tick.js:68:7)
at lastError (/var/lib/jenkins/workspace/elastic+kibana+master/JOB/x-pack-ciGroup7/node/immutable/kibana/test/common/services/retry/retry_for_success.ts:28:9)
at onFailure (/var/lib/jenkins/workspace/elastic+kibana+master/JOB/x-pack-ciGroup7/node/immutable/kibana/test/common/services/retry/retry_for_success.ts:68:13)]]>
</failure>
</testcase>
<testcase name="maps app &quot;after all&quot; hook" classname="Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/maps" time="0.179" metadata-json="{&quot;messages&quot;:[&quot;foo&quot;],&quot;screenshots&quot;:[{&quot;name&quot;:&quot;failure[dashboard app using current data dashboard snapshots compare TSVB snapshot]&quot;,&quot;url&quot;:&quot;https://storage.googleapis.com/kibana-ci-artifacts/jobs/elastic+kibana+7.x/1632/kibana-oss-tests/test/functional/screenshots/failure/dashboard%20app%20using%20current%20data%20dashboard%20snapshots%20compare%20TSVB%20snapshot.png&quot;}]}">
<system-out>
<![CDATA[[00:00:00] │
[00:07:04] └-: maps app
...
]]>
</system-out>
<failure>
<![CDATA[{ NoSuchSessionError: This driver instance does not have a valid session ID (did you call WebDriver.quit()?) and may no longer be used.
at promise.finally (/var/lib/jenkins/workspace/elastic+kibana+master/JOB/x-pack-ciGroup7/node/immutable/kibana/node_modules/selenium-webdriver/lib/webdriver.js:726:38)
at Object.thenFinally [as finally] (/var/lib/jenkins/workspace/elastic+kibana+master/JOB/x-pack-ciGroup7/node/immutable/kibana/node_modules/selenium-webdriver/lib/promise.js:124:12)

OpenSearch-Dashboards/packages/osd-test/src/failed_tests_reporter/__fixtures__/jest_report.xml

Lines 3 to 9 in 1caf907

<testsuite name="x-pack/legacy/plugins/code/server/lsp/abstract_launcher.test.ts" timestamp="2019-06-07T03:42:21" time="14.504" tests="5" failures="1" skipped="0" file="/var/lib/jenkins/workspace/elastic+kibana+master/JOB/x-pack-intake/node/immutable/kibana/x-pack/legacy/plugins/code/server/lsp/abstract_launcher.test.ts">
<testcase classname="X-Pack Jest Tests.x-pack/legacy/plugins/code/server/lsp" name="launcher can start and end a process" time="1.316"/>
<testcase classname="X-Pack Jest Tests.x-pack/legacy/plugins/code/server/lsp" name="launcher can force kill the process if langServer can not exit" time="3.182"/>
<testcase classname="X-Pack Jest Tests.x-pack/legacy/plugins/code/server/lsp" name="launcher can reconnect if process died" time="7.060">
<failure>
<![CDATA[TypeError: Cannot read property '0' of undefined
at Object.<anonymous>.test (/var/lib/jenkins/workspace/elastic+kibana+master/JOB/x-pack-intake/node/immutable/kibana/x-pack/legacy/plugins/code/server/lsp/abstract_launcher.test.ts:166:10)]]>

OpenSearch-Dashboards/packages/osd-test/src/failed_tests_reporter/__fixtures__/mocha_report.xml

Line 18 in 1caf907

at Function.getSnapshot (/var/lib/jenkins/workspace/elastic+kibana+master/JOB/x-pack-intake/node/immutable/kibana/packages/osd-opensearch/src/artifact.js:95:13)

OpenSearch-Dashboards/release-notes/opensearch-dashboards.release-notes-1.1.0.md

Line 201 in 1caf907

- [Changelog](https://github.com/Stuk/jszip/blob/master/CHANGES.md)

OpenSearch-Dashboards/src/core/server/core_app/assets/legacy_dark_theme.css

Line 15 in 1caf907

* Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE)

OpenSearch-Dashboards/src/core/server/core_app/assets/legacy_light_theme.css

Line 15 in 1caf907

* Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE)

OpenSearch-Dashboards/src/core/server/http/http_config.ts

Line 44 in 1caf907

// https://github.com/opensearch-project/OpenSearch-Dashboards/blob/master/src/legacy/server/config/schema.js

OpenSearch-Dashboards/src/core/server/plugins/discovery/plugin_manifest_parser.test.ts

Line 43 in 1caf907

branch: 'master',

OpenSearch-Dashboards/src/core/server/plugins/discovery/plugins_discovery.test.ts

Line 79 in 1caf907

branch: 'master',

OpenSearch-Dashboards/src/dev/ci_setup/checkout_sibling_opensearch.sh

Line 48 in 1caf907

echo "the OpenSearch Dashboards branch (first on your fork and then upstream) before building from master."

OpenSearch-Dashboards/src/dev/ci_setup/get_percy_env.js

Line 66 in 1caf907

// percy snapshots always target pkg.branch, so that feature branches can be based on master/7.x/etc.

OpenSearch-Dashboards/src/legacy/server/config/schema.js

Line 64 in 1caf907

// https://github.com/opensearch-project/OpenSearch-Dashboards/blob/master/src/core/server/http/http_config.ts

OpenSearch-Dashboards/src/plugins/embeddable/README.md

Lines 11 to 19 in 1caf907

Many example embeddables are implemented and registered [here](https://github.com/opensearch-project/OpenSearch-Dashboards/tree/master/examples/embeddable_examples). They can be played around with and explored [in the Embeddable Explorer example plugin](https://github.com/opensearch-project/OpenSearch-Dashboards/tree/master/examples/embeddable_explorer). Just run OpenSearch Dashboards with
```
yarn start --run-examples
```
and navigate to the Embeddable explorer app.
There is also an example of rendering dashboard container outside of dashboard app [here](https://github.com/opensearch-project/OpenSearch-Dashboards/tree/master/examples/dashboard_embeddable_examples).

OpenSearch-Dashboards/src/plugins/opensearch_dashboards_overview/README.md

Line 9 in 1caf907

See the [OpenSearch Dashboards contributing guide](https://github.com/opensearch-project/OpenSearch-Dashboards/blob/master/CONTRIBUTING.md) for instructions setting up your development environment.

OpenSearch-Dashboards/src/plugins/opensearch_dashboards_utils/common/state_containers/create_state_container_react_helpers.ts

Line 90 in 1caf907

* Refer to {@link https://github.com/opensearch-project/OpenSearch-Dashboards/blob/master/src/plugins/opensearch_dashboards_utils/docs/state_containers/react.md | guide} for details

OpenSearch-Dashboards/src/plugins/opensearch_dashboards_utils/common/state_containers/index.ts

Line 34 in 1caf907

* Refer to {@link https://github.com/opensearch-project/OpenSearch-Dashboards/tree/master/src/plugins/opensearch_dashboards_utils/docs/state_containers | guides and examples} for more info

OpenSearch-Dashboards/src/plugins/opensearch_dashboards_utils/common/state_containers/README.md

Line 2 in 1caf907

* [api reference](https://github.com/opensearch-project/OpenSearch-Dashboards/tree/master/src/plugins/opensearch_dashboards_utils/docs/state_containers)

OpenSearch-Dashboards/src/plugins/opensearch_dashboards_utils/public/state_sync/index.ts

Lines 35 to 47 in 1caf907

* They are designed to work together with {@link https://github.com/opensearch-project/OpenSearch-Dashboards/tree/master/src/plugins/opensearch_dashboards_utils/docs/state_containers | state containers}. But state containers are not required.
*
* State syncing utilities include:
*
* *{@link syncState} util which:
* * Subscribes to state changes and pushes them to state storage.
* * Optionally subscribes to state storage changes and pushes them to state.
* * Two types of storages compatible with `syncState`:
* * {@link IOsdUrlStateStorage} - Serializes state and persists it to URL's query param in rison or hashed format.
* Listens for state updates in the URL and pushes them back to state.
* * {@link ISessionStorageStateStorage} - Serializes state and persists it to browser storage.
*
* Refer {@link https://github.com/opensearch-project/OpenSearch-Dashboards/tree/master/src/plugins/opensearch_dashboards_utils/docs/state_sync | here} for a complete guide and examples.

OpenSearch-Dashboards/src/plugins/opensearch_dashboards_utils/public/state_sync/README.md

Line 3 in 1caf907

- [api reference](https://github.com/opensearch-project/OpenSearch-Dashboards/tree/master/src/plugins/opensearch_dashboards_utils/docs/state_sync)

OpenSearch-Dashboards/src/plugins/opensearch_dashboards_utils/public/state_sync/state_sync.ts

Line 67 in 1caf907

* Go {@link https://github.com/opensearch-project/OpenSearch-Dashboards/tree/master/src/plugins/opensearch_dashboards_utils/docs/state_sync | here} for a complete guide and examples.

OpenSearch-Dashboards/src/plugins/opensearch_dashboards_utils/public/state_sync/state_sync_state_storage/create_osd_url_state_storage.ts

Line 53 in 1caf907

* {@link https://github.com/opensearch-project/OpenSearch-Dashboards/blob/master/src/plugins/opensearch_dashboards_utils/docs/state_sync/storages/osd_url_storage.md | Refer to this guide for more info}

OpenSearch-Dashboards/src/plugins/opensearch_dashboards_utils/public/state_sync/state_sync_state_storage/create_session_storage_state_storage.ts

Lines 36 to 47 in 1caf907

* {@link https://github.com/opensearch-project/OpenSearch-Dashboards/blob/master/src/plugins/opensearch_dashboards_utils/docs/state_sync/storages/session_storage.md | guide}
* @public
*/
export interface ISessionStorageStateStorage extends IStateStorage {
set: <State>(key: string, state: State) => void;
get: <State = unknown>(key: string) => State | null;
}
/**
* TODO: Update link
* Creates {@link ISessionStorageStateStorage}
* {@link https://github.com/opensearch-project/OpenSearch-Dashboards/blob/master/src/plugins/opensearch_dashboards_utils/docs/state_sync/storages/session_storage.md | guide}

OpenSearch-Dashboards/src/test_utils/public/testbed/types.ts

Lines 184 to 186 in 1caf907

/** The React Router **initial entries** setting ([see documentation](https://github.com/ReactTraining/react-router/blob/master/packages/react-router/docs/api/MemoryRouter.md)) */
initialEntries?: string[];
/** The React Router **initial index** setting ([see documentation](https://github.com/ReactTraining/react-router/blob/master/packages/react-router/docs/api/MemoryRouter.md)) */

OpenSearch-Dashboards/tasks/docker_docs/Dockerfile

Line 18 in 1caf907

CMD git pull origin master && ./build_docs.pl --doc /home/kibana/ascii_docs/index.asciidoc --out /home/kibana/html_docs --chunk=1

@tmarkley tmarkley mentioned this issue Jun 7, 2022
Closed
8 tasks
@kaddy645
Copy link
Contributor

kaddy645 commented Jun 21, 2022 •
edited
Loading

@tmarkley I was validating the links and noticed many of the files does not exist! few things to discuss.

  1. https://github.com/opensearch-project/OpenSearch-Dashboards/tree/main/src/plugins/foo/README.md Here we don't have foo folder, I am assuming it was just testing folder ?

  2. We do not have docs folder at the moment! Some of the links (around 6 )are pointing to docs folder ! I found this PR where we are removing docs folder!
    e.g
    Link - 1

  3. Some of the links are external so main/master not required ?
    https://github.com/yahoo/intl-messageformat/blob/master/src/core.js#L62

  4. Are we also suppose make changes in xml files ? e.g

mocha_report.xml

jest_report.xml

@tmarkley
Copy link
Contributor Author

  1. https://github.com/opensearch-project/OpenSearch-Dashboards/tree/main/src/plugins/foo/README.md Here we don't have foo folder, I am assuming it was just testing folder ?

Yes this is just an example. We can still change master to main.

  1. We do not have docs folder at the moment! Some of the links (around 6 )are pointing to docs folder ! I found this PR where we are removing docs folder!

Correct, the docs folder does not exist anymore.

  1. Some of the links are external so main/master not required ?
    https://github.com/yahoo/intl-messageformat/blob/master/src/core.js#L62

Yeah, for some of these I think the branches did changes from master to main, but if not then we can leave them alone. For that link in particular it looks like the file name was changed: https://github.com/formatjs/intl-messageformat/blob/master/src/core.ts

4. Are we also suppose make changes in xml files ? e.g

mocha_report.xml

jest_report.xml

I actually don't think we need these files anymore because they seem to be related to x-pack:

OpenSearch-Dashboards/packages/osd-test/src/failed_tests_reporter/add_messages_to_report.test.ts

Lines 213 to 218 in 89d3872

classname: 'X-Pack Mocha Tests.x-pack/legacy/plugins/code/server/__tests__/multi_node·ts',
message: 'foo bar',
},
],
log,
reportPath: Path.resolve(__dirname, './__fixtures__/mocha_report.xml'),

OpenSearch-Dashboards/packages/osd-test/src/failed_tests_reporter/add_messages_to_report.test.ts

Lines 165 to 171 in 89d3872

classname: 'X-Pack Jest Tests.x-pack/legacy/plugins/code/server/lsp',
name: 'launcher can reconnect if process died',
message: 'foo bar',
},
],
log,
reportPath: Path.resolve(__dirname, './__fixtures__/jest_report.xml'),

Those can be handled in a separate issue/PR.

@kaddy645
Copy link
Contributor

Sounds good to me!

@kaddy645 kaddy645 mentioned this issue Jun 22, 2022
Merged
7 tasks
@kavilla kavilla linked a pull request Jun 23, 2022 that will close this issue
[Non-Inclusive Lanuage] Replace references to master branch with main #1780
Merged
7 tasks
kavilla pushed a commit that referenced this issue Jun 23, 2022
@kaddy645
[Non-Inclusive Lanuage] Replace references to master branch with main (…
7c8eee4 
…#1780)

In this change, we are replacing references to master branch with main

Issue:
#1691

Signed-off-by: kaddy645 <xdeskart@amazon.com>
kavilla pushed a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Jun 23, 2022
@kaddy645 @kavilla
[Non-Inclusive Lanuage] Replace references to master branch with main (…
e580552 
…opensearch-project#1780)

In this change, we are replacing references to master branch with main

Issue:
opensearch-project#1691

Signed-off-by: kaddy645 <xdeskart@amazon.com>
(cherry picked from commit 7c8eee4)
kavilla pushed a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Jun 23, 2022
@kaddy645 @kavilla
[Non-Inclusive Lanuage] Replace references to master branch with main (…
0bfb235 
…opensearch-project#1780)

In this change, we are replacing references to master branch with main

Issue:
opensearch-project#1691

Signed-off-by: kaddy645 <xdeskart@amazon.com>
(cherry picked from commit 7c8eee4)

Signed-off-by: <Kartik Desai xdeskart@amazon.com>
kavilla pushed a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Jun 23, 2022
@kaddy645 @kavilla
[Non-Inclusive Lanuage] Replace references to master branch with main (…
4df8d8a 
…opensearch-project#1780)

In this change, we are replacing references to master branch with main

Issue:
opensearch-project#1691

Signed-off-by: kaddy645 <xdeskart@amazon.com>
(cherry picked from commit 7c8eee4)

Signed-off-by: Kartik Desai <xdeskart@amazon.com>
joshuarrrr pushed a commit that referenced this issue Jun 24, 2022
@kavilla @kaddy645
[Non-Inclusive Lanuage] Replace references to master branch with main (…
99fe9dc 
…#1780) (#1790)

In this change, we are replacing references to master branch with main

Issue:
#1691

Signed-off-by: kaddy645 <xdeskart@amazon.com>
(cherry picked from commit 7c8eee4)

Signed-off-by: Kartik Desai <xdeskart@amazon.com>

Co-authored-by: Kartik Desai <xdeskart@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaddy645 kaddy645

Labels
non-inclusive language v2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Non-Inclusive Lanuage] Replace references to master branch with main kaddy645/OpenSearch-Dashboards
2 participants
@tmarkley @kaddy645