[Data Explorer] Fix functional cigroup 3 for save search on dashboard…

… filtering (#5111) * fix cigroup3 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix error Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
opensearch-project · Sep 26, 2023 · da3c209 · da3c209
1 parent 64f6746
commit da3c209
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 8 deletions.
diff --git a/test/functional/apps/dashboard/dashboard_filter_bar.js b/test/functional/apps/dashboard/dashboard_filter_bar.js
@@ -193,7 +193,12 @@ export default function ({ getService, getPageObjects }) {
       it('are added when a cell magnifying glass is clicked', async function () {
         await dashboardAddPanel.addSavedSearch('Rendering-Test:-saved-search');
         await PageObjects.dashboard.waitForRenderComplete();
-        await testSubjects.click('docTableCellFilter');
+
+        // Expand a doc row
+        await testSubjects.click('docTableExpandToggleColumn-0');
+
+        // Add a field filter
+        await testSubjects.click('tableDocViewRow-@message > addInclusiveFilterButton');
 
         const filterCount = await filterBar.getFilterCount();
         expect(filterCount).to.equal(1);

diff --git a/test/functional/apps/dashboard/dashboard_filtering.js b/test/functional/apps/dashboard/dashboard_filtering.js
@@ -123,7 +123,7 @@ export default function ({ getService, getPageObjects }) {
       });
 
       it('saved search is filtered', async () => {
-        await dashboardExpect.savedSearchRowCount(0);
+        await testSubjects.missingOrFail('euiDataGrid');
       });
 
       it('vega is filtered', async () => {
@@ -171,7 +171,7 @@ export default function ({ getService, getPageObjects }) {
       });
 
       it('saved search is filtered', async () => {
-        await dashboardExpect.savedSearchRowCount(0);
+        await testSubjects.missingOrFail('euiDataGrid');
       });
 
       it('vega is filtered', async () => {

diff --git a/test/functional/services/dashboard/expectations.ts b/test/functional/services/dashboard/expectations.ts
@@ -36,6 +36,7 @@ export function DashboardExpectProvider({ getService, getPageObjects }: FtrProvi
   const log = getService('log');
   const retry = getService('retry');
   const testSubjects = getService('testSubjects');
+  const dataGrid = getService('dataGrid');
   const find = getService('find');
   const filterBar = getService('filterBar');
   const PageObjects = getPageObjects(['dashboard', 'visualize']);
@@ -233,11 +234,9 @@ export function DashboardExpectProvider({ getService, getPageObjects }: FtrProvi
     async savedSearchRowCount(expectedCount: number) {
       log.debug(`DashboardExpect.savedSearchRowCount(${expectedCount})`);
       await retry.try(async () => {
-        const savedSearchRows = await testSubjects.findAll(
-          'docTableExpandToggleColumn',
-          findTimeout
-        );
-        expect(savedSearchRows.length).to.be(expectedCount);
+        // Need to change it here to find out how many rows there are
+        const timeStamps = await dataGrid.getDataGridTableColumn('date');
+        expect(timeStamps.length).to.be(expectedCount);
       });
     }
 

diff --git a/test/functional/services/data_grid.ts b/test/functional/services/data_grid.ts
@@ -42,6 +42,7 @@ export function DataGridProvider({ getService }: FtrProviderContext) {
   class DataGrid {
     // This test no longer works in the new data explorer data grid table
     // since each data grid table cell is now rendered differently
+    // https://github.com/opensearch-project/OpenSearch-Dashboards/issues/5108
     async getDataGridTableData(): Promise<TabbedGridData> {
       const table = await find.byCssSelector('.euiDataGrid');
       const $ = await table.parseDomContent();