Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Run.bat for EasyEDA #140

Merged
merged 4 commits into from
Apr 11, 2020

Conversation

scarrrr316
Copy link
Contributor

dont need to open cmd , just double click this batch file and drag the EasyEDA source file

dont need to open cmd , just double click this batch file and drag the EasyEDA source file
Copy link
Member

@qu1ck qu1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR, I like this idea.

It would be great if the bat file would use KiCad's python when available instead of whatever is on the PATH. In that case the bat file would work for both easyeda and kicad files.

You can find kicad python by getting this registry key
HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\Windows\CurrentVersion\Uninstall\KiCad\InstallLocation

and appending \bin\python.exe
Obviously check that reg key exists and file exists before falling back to system python.

InteractiveHtmlBom/Run.bat Outdated Show resolved Hide resolved
InteractiveHtmlBom/Run.bat Outdated Show resolved Hide resolved
InteractiveHtmlBom/Run.bat Outdated Show resolved Hide resolved
InteractiveHtmlBom/Run.bat Outdated Show resolved Hide resolved
InteractiveHtmlBom/Run.bat Outdated Show resolved Hide resolved
Copy link
Member

@qu1ck qu1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for previous comments

@qu1ck
Copy link
Member

qu1ck commented Apr 11, 2020

Thanks. Do you want to try to make it kicad compatible like I explained above?
If not that's fine, this is good enough to merge. I'll take a stab at kicad compatibility later.

@scarrrr316
Copy link
Contributor Author

scarrrr316 commented Apr 11, 2020

oh, I have never used kicad, so I dont know that python

@qu1ck qu1ck merged commit f346175 into openscopeproject:master Apr 11, 2020
@scarrrr316
Copy link
Contributor Author

scarrrr316 commented Apr 11, 2020

can I use this command to convert kicad file?
python %pyfilepath%generate_interactive_bom.py kicadfile
other use other method
And I saw that there are some files created by venv,and the files were not complete,how can I compete it ? Make it run without python of kicad or local.

@qu1ck
Copy link
Member

qu1ck commented Apr 11, 2020

can I use this command to convert kicad file?
python %pyfilepath%generate_interactive_bom.py kicadfile

Yes, except it needs to be python packaged with kicad, i.e. something like this:
C:\Program Files\Kicad\bin\python.exe ...

I posted above the registry key that stores kicad install location.

And I saw that there are some files created by venv,and the files were not complete,how can I compete it ? Make it run without python of kicad or local.

Not sure what you mean

@scarrrr316
Copy link
Contributor Author

emmmm ,I mean use virtualenv to create virtual python environment

@qu1ck
Copy link
Member

qu1ck commented Apr 12, 2020

And what is the issue with virtualenv? What files are not complete?

scarrrr316 added a commit to scarrrr316/InteractiveHtmlBom that referenced this pull request Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants