Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

86 pytest regressions #88

Merged
merged 6 commits into from
Jan 29, 2024
Merged

86 pytest regressions #88

merged 6 commits into from
Jan 29, 2024

Conversation

znicholls
Copy link
Collaborator

@znicholls znicholls commented Jan 22, 2024

Description

Closes #86

Checklist

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Changelog item added to changelog/

@znicholls znicholls marked this pull request as ready for review January 22, 2024 15:31
@znicholls znicholls force-pushed the 86-pytest-regressions branch from 948d82a to 7524c93 Compare January 22, 2024 15:31
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (363f801) 69.86% compared to head (b3c8cbf) 70.38%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   69.86%   70.38%   +0.51%     
==========================================
  Files          36       36              
  Lines        1457     1442      -15     
  Branches      197      194       -3     
==========================================
- Hits         1018     1015       -3     
+ Misses        415      405      -10     
+ Partials       24       22       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@znicholls znicholls requested a review from lewisjared January 23, 2024 08:15
@znicholls
Copy link
Collaborator Author

@maritsandstad once this is merged, that's a good time for you to update ciceroscmpy to handle pandas > 2 :)

@znicholls znicholls merged commit ef87183 into master Jan 29, 2024
19 checks passed
@znicholls znicholls deleted the 86-pytest-regressions branch January 29, 2024 06:41
Copy link

@925209391 925209391 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mesmer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to pytest-regressions
2 participants