-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ciceroscm py #78
Add ciceroscm py #78
Conversation
Yeah, seems to be an issue with MAGICC's Fortran libraries on macOS:
Maybe there is a mismatch of required libraries for the compiled downloaded version and what's available on the CI images. |
I fixed this in #79. The mac ci image changed and the gfortran dylib was moved/not exposed in the same way. I'm not an expert with making Mac binarys that work anywhere so there might have been something we could fix at compile time |
Thanks @lewisjared! |
Thank you @lewisjared and @rgieseke! Things seem to all go green now;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Merge if you're happy @maritsandstad
I'm very happy ;-) |
As long as nothing explodes, this should be released as part of v0.11.0 https://github.com/openscm/openscm-runner/actions/runs/2881581512 |
Adding ciceroscm, this time with a branch with correct origin...
CHANGELOG.rst
added (single line such as:(`#XX <https://github.com/openscm/openscm-runner/pull/XX>`_) Added feature which does something
)