Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ciceroscm py #78

Merged
merged 16 commits into from
Aug 18, 2022
Merged

Add ciceroscm py #78

merged 16 commits into from
Aug 18, 2022

Conversation

maritsandstad
Copy link
Collaborator

@maritsandstad maritsandstad commented Aug 5, 2022

Adding ciceroscm, this time with a branch with correct origin...

  • Tests added
  • Documentation added
  • Example added (in the documentation, to an existing notebook, or in a new notebook)
  • Description in CHANGELOG.rst added (single line such as: (`#XX <https://github.com/openscm/openscm-runner/pull/XX>`_) Added feature which does something)

@maritsandstad maritsandstad temporarily deployed to CI August 5, 2022 07:19 Inactive
@maritsandstad maritsandstad temporarily deployed to CI August 5, 2022 07:19 Inactive
@maritsandstad maritsandstad temporarily deployed to CI August 5, 2022 07:20 Inactive
@maritsandstad maritsandstad temporarily deployed to CI August 5, 2022 07:20 Inactive
@maritsandstad maritsandstad temporarily deployed to CI August 5, 2022 07:20 Inactive
@maritsandstad maritsandstad temporarily deployed to CI August 5, 2022 07:20 Inactive
@maritsandstad maritsandstad temporarily deployed to CI August 5, 2022 07:20 Inactive
@maritsandstad maritsandstad temporarily deployed to CI August 5, 2022 07:20 Inactive
@maritsandstad maritsandstad temporarily deployed to CI August 5, 2022 07:20 Inactive
@maritsandstad maritsandstad temporarily deployed to CI August 5, 2022 07:20 Inactive
@maritsandstad maritsandstad temporarily deployed to CI August 5, 2022 07:20 Inactive
@maritsandstad maritsandstad temporarily deployed to CI August 5, 2022 07:20 Inactive
@rgieseke
Copy link
Member

Yeah, seems to be an issue with MAGICC's Fortran libraries on macOS:

dyld: Library not loaded: /usr/local/opt/gcc/lib/gcc/11/libgfortran.5.dylib
  Referenced from: /Users/runner/work/openscm-runner/openscm-runner/bin/magicc/magicc-v7.5.3/bin/magicc-darwin-amd64
  Reason: image not found
ImportError while loading conftest '/Users/runner/work/openscm-runner/openscm-runner/tests/conftest.py'.
tests/conftest.py:50: in <module>
    MAGICC_VERSION = MAGICC7.get_version()
src/openscm_runner/adapters/magicc7/magicc7.py:213: in get_version
    return check_output([cls._executable(), "--version"]).decode("utf-8").strip()
../../../hostedtoolcache/Python/3.9.13/x64/lib/python3.9/subprocess.py:424: in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
../../../hostedtoolcache/Python/3.9.13/x64/lib/python3.9/subprocess.py:528: in run
    raise CalledProcessError(retcode, process.args,
E   subprocess.CalledProcessError: Command '['bin/magicc/magicc-v7.5.3/bin/magicc-darwin-amd64', '--version']' died with <Signals.SIGABRT: 6>.
Error: Process completed with exit code 4.

Maybe there is a mismatch of required libraries for the compiled downloaded version and what's available on the CI images.

@lewisjared
Copy link
Collaborator

I fixed this in #79. The mac ci image changed and the gfortran dylib was moved/not exposed in the same way.

I'm not an expert with making Mac binarys that work anywhere so there might have been something we could fix at compile time

@rgieseke
Copy link
Member

Thanks @lewisjared!
I've merged #79 so after merging the main branch and fixing the conflicts this should hopefully work, @maritsandstad

@maritsandstad maritsandstad temporarily deployed to CI August 18, 2022 07:17 Inactive
@maritsandstad maritsandstad temporarily deployed to CI August 18, 2022 07:17 Inactive
@maritsandstad maritsandstad temporarily deployed to CI August 18, 2022 07:17 Inactive
@maritsandstad maritsandstad temporarily deployed to CI August 18, 2022 07:17 Inactive
@maritsandstad maritsandstad temporarily deployed to CI August 18, 2022 07:17 Inactive
@maritsandstad maritsandstad temporarily deployed to CI August 18, 2022 07:17 Inactive
@maritsandstad maritsandstad temporarily deployed to CI August 18, 2022 07:17 Inactive
@maritsandstad maritsandstad temporarily deployed to CI August 18, 2022 07:17 Inactive
@maritsandstad maritsandstad temporarily deployed to CI August 18, 2022 07:17 Inactive
@maritsandstad maritsandstad temporarily deployed to CI August 18, 2022 07:17 Inactive
@maritsandstad maritsandstad temporarily deployed to CI August 18, 2022 07:17 Inactive
@maritsandstad maritsandstad temporarily deployed to CI August 18, 2022 07:17 Inactive
@maritsandstad
Copy link
Collaborator Author

Thank you @lewisjared and @rgieseke!

Things seem to all go green now;-)

Copy link
Collaborator

@znicholls znicholls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merge if you're happy @maritsandstad

@maritsandstad
Copy link
Collaborator Author

LGTM! Merge if you're happy @maritsandstad

I'm very happy ;-)

@maritsandstad maritsandstad merged commit b4c6fa0 into master Aug 18, 2022
znicholls added a commit that referenced this pull request Aug 18, 2022
@znicholls
Copy link
Collaborator

As long as nothing explodes, this should be released as part of v0.11.0 https://github.com/openscm/openscm-runner/actions/runs/2881581512

@znicholls znicholls deleted the add-ciceroscm-py branch August 18, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants