Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds TLS support for STOMP connections #16

Merged
merged 4 commits into from
Feb 7, 2023
Merged

Adds TLS support for STOMP connections #16

merged 4 commits into from
Feb 7, 2023

Conversation

kazeborja
Copy link
Contributor

This PR aims to provide TLS support for STOMP connections using certificates.
This is needed as at CERN TLS authentication is handled using certificates.

djw8605
djw8605 requested changes Feb 1, 2023
View reviewed changes
Copy link
Member

@djw8605 djw8605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Go standard is to use tabs, not spaces, for indention. The rest of the files are tab separated. I believe you can reformat the files with the command:

$ go fmt

config/config.yaml Outdated Show resolved Hide resolved
kazeborja and others added 2 commits February 2, 2023 08:46
@kazeborja
Apply go fmt
e46f683
@kazeborja @djw8605
Comment line from example config.yaml
a1ab484 
Co-authored-by: Derek Weitzel <djw8605@gmail.com>
@kazeborja
Copy link
Contributor Author

Thanks Derek for the pointers, I always forget about go fmt tool

@kazeborja kazeborja requested a review from djw8605 February 6, 2023 08:31
djw8605
djw8605 approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@djw8605 djw8605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djw8605 djw8605 merged commit 4ab70ab into opensciencegrid:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djw8605 djw8605 djw8605 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazeborja @djw8605