Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to convert kapel output records to Gratia records #183

Merged
merged 23 commits into from
Aug 14, 2024

Conversation

mwestphall
Copy link
Contributor

  • Add a new docker image that can be used as the second stage in the kapel processing pipeline

mwestphall and others added 20 commits April 9, 2024 10:30
Executables shouldn't really live in /etc so we pop all the Python
scripts in the container into a /gratia root dir
Add build pipeline, align k8s probe name with existing probes (SOFTWARE-5835)
Differentiate k8s probes in the ProbeName (SOFTWARE-5835)
@mwestphall mwestphall requested a review from brianhlin August 6, 2024 22:16
Copy link
Member

@brianhlin brianhlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments but otherwise LGTM

reponame="osg-htc/gratia-probe-k8s"
tags=()
for registry in docker.io hub.opensciencegrid.org; do
tags+=("$registry/$reponame:release")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we pull things out of OSG 23, we should probably align tags, e.g. 23-release

Comment on lines 1 to 4
# Useful for handling configuration
environs
# Useful for adding messages to outgoing queue
dirq
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can / should we version lock these?

yield records

def main(envFile: str):
print(f'Starting Gratia post-processor: {__file__} with envFile {envFile} at {datetime.now(tz=timezone.utc).isoformat()}')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also dump the contents of the env file? It could be helpful for debugging.

@mwestphall mwestphall merged commit cbb05d8 into opensciencegrid:2.x Aug 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants