-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to convert kapel output records to Gratia records #183
Conversation
mwestphall
commented
Aug 6, 2024
- Add a new docker image that can be used as the second stage in the kapel processing pipeline
(SOFTWARE-5835)
Executables shouldn't really live in /etc so we pop all the Python scripts in the container into a /gratia root dir
Add build pipeline, align k8s probe name with existing probes (SOFTWARE-5835)
Differentiate k8s probes in the ProbeName (SOFTWARE-5835)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments but otherwise LGTM
reponame="osg-htc/gratia-probe-k8s" | ||
tags=() | ||
for registry in docker.io hub.opensciencegrid.org; do | ||
tags+=("$registry/$reponame:release") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we pull things out of OSG 23, we should probably align tags, e.g. 23-release
kubernetes/requirements.txt
Outdated
# Useful for handling configuration | ||
environs | ||
# Useful for adding messages to outgoing queue | ||
dirq |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can / should we version lock these?
yield records | ||
|
||
def main(envFile: str): | ||
print(f'Starting Gratia post-processor: {__file__} with envFile {envFile} at {datetime.now(tz=timezone.utc).isoformat()}') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also dump the contents of the env file? It could be helpful for debugging.