fix(editing): set false attribute values on update #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JakobVogelsang this itty bitty buggy fixy again does not come with a regression test or a bug issue and is therefore still a draft. If nobody else finds the time to add those this week, I'll add them next week and turn the draft into a pull request then. |
Since we switched from Replace to Update, we now no longer set falsey attribute values (like the empty string `''` or `0`). This fixes that issue.
Oh - my youthfully naive optimism from July is coming back to haunt me... 😅 |
1e6cc4e to
49d4d29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we switched from Replace to Update, we now no longer set falsey attribute values (like the empty string
''or0). This pull request fixes that issue.