fix: Adding Subnetwork to a configuration without a Communication Ele… #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment failed for the first time When creating a `Communication` Element in Communication.ts, the created Element is also returned to use it as a parent for the wizard The `Should create a Communication Element` integration test is extended to also check that the Wizard is closed properly Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
JakobVogelsang
requested changes
Jul 14, 2022
…ment failed for the first time When creating a `Communication` Element in Communication.ts, the created Element is also returned to use it as a parent for the wizard The `Should create a Communication Element` integration test is extended to also check that the Wizard is closed properly Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
…ment failed for the first time When creating a `Communication` Element in Communication.ts, the created Element is also returned to use it as a parent for the wizard The `Should create a Communication Element` integration test is extended to also check that the Wizard is closed properly Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
…ment failed for the first time When creating a `Communication` Element in Communication.ts, the created Element is also returned to use it as a parent for the wizard The `Should create a Communication Element` integration test is extended to also check that the Wizard is closed properly Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
JakobVogelsang
requested changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #847
…ment failed for the first time
When creating a
CommunicationElement in Communication.ts, the created Element is also returned to use it as a parent for the wizardThe
Should create a Communication Elementintegration test is extended to also check that the Wizard is closed properlySigned-off-by: Pascal Wilbrink pascal.wilbrink@alliander.com