Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editors/template): make sure that edit wizards are always opened #845

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

JakobVogelsang
Copy link
Collaborator

@JakobVogelsang JakobVogelsang commented Jul 4, 2022

Closes #824 .

Simple thing, but to remember for the future. When using @selected on a mwc-list and therefore also filtered-list will only fire when the selection has been changed. For the used case we have here: reacting on any click in the list action is the one to go for.

@JakobVogelsang JakobVogelsang added this to the Sprint 2022-07-11 milestone Jul 4, 2022
@JakobVogelsang JakobVogelsang self-assigned this Jul 4, 2022
Copy link
Contributor

@ca-d ca-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix and the extensive tests!

@JakobVogelsang JakobVogelsang merged commit 15c2d3b into main Jul 5, 2022
@JakobVogelsang JakobVogelsang deleted the fix-template-editor-edit-wizard-trigger branch July 5, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wizard not started for the second time for same Entry in Template Editor
2 participants