Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wizard-dialog): remove initialFocus from action buttons #702

Merged
merged 1 commit into from
Apr 25, 2022
Merged

fix(wizard-dialog): remove initialFocus from action buttons #702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/wizard-dialog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,6 @@ export class WizardDialog extends LitElement {
icon="code"
label="${translate('save')}"
trailingIcon
dialogInitialFocus
></mwc-button>`
: page.primary
? html`<mwc-button
Expand All @@ -366,7 +365,6 @@ export class WizardDialog extends LitElement {
icon="${page.primary.icon}"
label="${page.primary.label}"
trailingIcon
dialogInitialFocus
></mwc-button>`
: index + 1 < (this.wizard?.length ?? 0)
? html`<mwc-button
Expand Down
1 change: 0 additions & 1 deletion .../integration/editors/communication/__snapshots__/subnetwork-editor-wizarding.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ snapshots["subnetwork-editor wizarding integration edit/add Subnetwork wizard lo
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon="save"
label="[save]"
slot="primaryAction"
Expand Down
2 changes: 0 additions & 2 deletions test/integration/editors/templates/__snapshots__/datype-wizarding.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,7 +603,6 @@ snapshots["DAType wizards defines a createDATypeWizard looks like the latest sna
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon="add"
label="[add]"
slot="primaryAction"
Expand Down Expand Up @@ -772,7 +771,6 @@ snapshots["DAType wizards defines a dATypeWizard looks like the latest snapshot"
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon=""
label="[save]"
slot="primaryAction"
Expand Down
4 changes: 0 additions & 4 deletions test/integration/editors/templates/__snapshots__/dotype-wizarding.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,7 +706,6 @@ snapshots["DOType wizards defines a createDOTypeWizard looks like the latest sna
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon="add"
label="[add]"
slot="primaryAction"
Expand Down Expand Up @@ -1021,7 +1020,6 @@ snapshots["DOType wizards defines a dOTypeWizard looks like the latest snapshot"
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon=""
label="[save]"
slot="primaryAction"
Expand Down Expand Up @@ -1233,7 +1231,6 @@ snapshots["DOType wizards defines a sDOWizard to edit an existing SDO looks like
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon=""
label="[save]"
slot="primaryAction"
Expand Down Expand Up @@ -1419,7 +1416,6 @@ snapshots["DOType wizards defines a sDOWizard to create a new SDO element looks
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon=""
label="[save]"
slot="primaryAction"
Expand Down
4 changes: 0 additions & 4 deletions test/integration/editors/templates/__snapshots__/enumtype-wizarding.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1355,7 +1355,6 @@ snapshots["EnumType wizards defines a createEnumTypeWizard looks like the latest
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon="add"
label="[add]"
slot="primaryAction"
Expand Down Expand Up @@ -1515,7 +1514,6 @@ snapshots["EnumType wizards defines an eNumTypeEditWizard looks like the latest
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon=""
label="[save]"
slot="primaryAction"
Expand Down Expand Up @@ -1589,7 +1587,6 @@ snapshots["EnumType wizards defines a eNumValWizard to edit an existing EnumVal
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon=""
label="Save"
slot="primaryAction"
Expand Down Expand Up @@ -1639,7 +1636,6 @@ snapshots["EnumType wizards defines a eNumValWizard to create a new EnumVal elem
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon=""
label="Save"
slot="primaryAction"
Expand Down
4 changes: 0 additions & 4 deletions test/integration/editors/templates/__snapshots__/lnodetype-wizard.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,6 @@ snapshots["LNodeType wizards defines a lNodeTypeHelperWizard looks like the late
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon=""
label="[save]"
slot="primaryAction"
Expand Down Expand Up @@ -4339,7 +4338,6 @@ snapshots["LNodeType wizards defines a createLNodeTypeWizard looks like the late
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon=""
label="[next]..."
slot="primaryAction"
Expand Down Expand Up @@ -4674,7 +4672,6 @@ snapshots["LNodeType wizards defines a createLNodeTypeWizard opens a createLNode
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon=""
label="[save]"
slot="primaryAction"
Expand Down Expand Up @@ -4874,7 +4871,6 @@ snapshots["LNodeType wizards defines a dOWizard to create a new DO element looks
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon=""
label="[save]"
slot="primaryAction"
Expand Down
2 changes: 0 additions & 2 deletions test/integration/wizards/__snapshots__/bda-wizarding-editing.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,7 +618,6 @@ snapshots["BDA wizarding editing integration defines a editBDaWizard to edit an
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon=""
label="[save]"
slot="primaryAction"
Expand Down Expand Up @@ -1155,7 +1154,6 @@ snapshots["BDA wizarding editing integration defines a createBDaWizard to create
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon=""
label="[save]"
slot="primaryAction"
Expand Down
2 changes: 0 additions & 2 deletions test/integration/wizards/__snapshots__/da-wizarding-editing.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,7 +807,6 @@ snapshots["DA wizarding editing integration defines a editDaWizard to edit an ex
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon=""
label="[save]"
slot="primaryAction"
Expand Down Expand Up @@ -1526,7 +1525,6 @@ snapshots["DA wizarding editing integration defines a createDaWizard to create a
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon=""
label="[save]"
slot="primaryAction"
Expand Down
1 change: 0 additions & 1 deletion test/integration/zeroline/__snapshots__/bay-editor-wizarding.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ snapshots["bay-editor wizarding integration looks like the latest snapshot"] =
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon="edit"
label="[save]"
slot="primaryAction"
Expand Down
1 change: 0 additions & 1 deletion test/integration/zeroline/__snapshots__/conducting-equipment-editor-wizarding.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ snapshots["conducting-equipment-editor wizarding integration looks like the late
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon="edit"
label="[save]"
slot="primaryAction"
Expand Down
1 change: 0 additions & 1 deletion test/integration/zeroline/__snapshots__/substation-editor-wizarding.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ snapshots["substation-editor wizarding integration looks like the latest snapsho
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon="edit"
label="[save]"
slot="primaryAction"
Expand Down
1 change: 0 additions & 1 deletion test/integration/zeroline/__snapshots__/voltage-level-editor-wizarding.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ snapshots["voltage-level-editor wizarding integration looks like the latest snap
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon="edit"
label="[save]"
slot="primaryAction"
Expand Down
1 change: 0 additions & 1 deletion test/unit/editors/singlelinediagram/wizards/__snapshots__/bay.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ snapshots["Wizards for SCL element Bay (X/Y) looks like the latest snapshot"] =
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon="edit"
label="[save]"
slot="primaryAction"
Expand Down
1 change: 0 additions & 1 deletion test/unit/editors/singlelinediagram/wizards/__snapshots__/conductingequipment.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ snapshots["Wizards for SCL element Conducting Equipment (X/Y) looks like the lat
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon="edit"
label="[save]"
slot="primaryAction"
Expand Down
1 change: 0 additions & 1 deletion test/unit/editors/singlelinediagram/wizards/__snapshots__/powertransformer.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ snapshots["Wizards for SCL element Power Transformer (X/Y) looks like the latest
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon="edit"
label="[save]"
slot="primaryAction"
Expand Down
2 changes: 0 additions & 2 deletions test/unit/menu/__snapshots__/UpdateDescriptionSEL.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,6 @@ snapshots["Update method for desc attributes in SEL IEDs working on SCL files co
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon="save"
label="Save"
slot="primaryAction"
Expand Down Expand Up @@ -272,7 +271,6 @@ snapshots["Update method for desc attributes in SEL IEDs working on SCL files co
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon="save"
label="Save"
slot="primaryAction"
Expand Down
2 changes: 0 additions & 2 deletions test/unit/menu/__snapshots__/UpdateDescritionABB.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ snapshots["Update method for desc attributes in ABB IEDs working on SCL files wi
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon="save"
label="[save]"
slot="primaryAction"
Expand Down Expand Up @@ -80,7 +79,6 @@ snapshots["Update method for desc attributes in ABB IEDs working on SCL files co
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon="save"
label="[save]"
slot="primaryAction"
Expand Down
2 changes: 0 additions & 2 deletions test/unit/wizards/__snapshots__/clientln.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,6 @@ snapshots["clientln wizards createClientLnWizard looks like the latest snapshot"
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon=""
label="[connect]"
slot="primaryAction"
Expand Down Expand Up @@ -390,7 +389,6 @@ snapshots["clientln wizards selectClientLnWizard looks like the latest snapshot"
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon="delete"
label="[disconnect]"
slot="primaryAction"
Expand Down
3 changes: 0 additions & 3 deletions test/unit/wizards/__snapshots__/connectedap-pattern.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ snapshots["Edit wizard for SCL element ConnectedAP include an edit wizard that f
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon="save"
label="[save]"
slot="primaryAction"
Expand Down Expand Up @@ -294,7 +293,6 @@ snapshots["Edit wizard for SCL element ConnectedAP include an edit wizard that f
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon="save"
label="[save]"
slot="primaryAction"
Expand Down Expand Up @@ -533,7 +531,6 @@ snapshots["Edit wizard for SCL element ConnectedAP include an edit wizard that f
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon="save"
label="[save]"
slot="primaryAction"
Expand Down
1 change: 0 additions & 1 deletion test/unit/wizards/__snapshots__/connectedap.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ snapshots["Wizards for SCL element ConnectedAP include a create wizard that look
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon="save"
label="[save]"
slot="primaryAction"
Expand Down
1 change: 0 additions & 1 deletion test/unit/wizards/__snapshots__/controlwithiedname.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,6 @@ snapshots["selectExtRefWizard looks like the latest snapshot"] =
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon="delete"
label="[disconnect]"
slot="primaryAction"
Expand Down
1 change: 0 additions & 1 deletion test/unit/wizards/__snapshots__/dai.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ snapshots["Wizards for SCL element DAI edit existing DAI looks like the latest s
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon="edit"
label="[save]"
slot="primaryAction"
Expand Down
1 change: 0 additions & 1 deletion test/unit/wizards/__snapshots__/dataset.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ snapshots["dataset wizards include a dataset edit wizard looks like the latest s
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon="save"
label="[save]"
slot="primaryAction"
Expand Down
1 change: 0 additions & 1 deletion test/unit/wizards/__snapshots__/fcda.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ snapshots["create wizard for FCDA element with a valid SCL file looks like the l
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon="add"
label="add"
slot="primaryAction"
Expand Down
1 change: 0 additions & 1 deletion test/unit/wizards/__snapshots__/gse.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ snapshots["gse wizards editGseWizard looks like the latest snapshot"] =
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon="save"
label="[save]"
slot="primaryAction"
Expand Down
4 changes: 0 additions & 4 deletions test/unit/wizards/__snapshots__/gsecontrol.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ snapshots["gsecontrol wizards selectGseControlWizard looks like the latest snaps
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon="add"
label="[GOOSE]"
slot="primaryAction"
Expand Down Expand Up @@ -326,7 +325,6 @@ snapshots["gsecontrol wizards editGseControlWizard looks like the latest snapsho
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon="save"
label="[save]"
slot="primaryAction"
Expand Down Expand Up @@ -560,7 +558,6 @@ snapshots["gsecontrol wizards define an create wizard that with existing Connect
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon="save"
label="[save]"
slot="primaryAction"
Expand Down Expand Up @@ -627,7 +624,6 @@ snapshots["gsecontrol wizards define a wizard to select the control block refere
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon=""
label="[next]"
slot="primaryAction"
Expand Down
1 change: 0 additions & 1 deletion test/unit/wizards/__snapshots__/ied.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ snapshots["Wizards for SCL element IED edit existing IED looks like the latest s
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon="edit"
label="[save]"
slot="primaryAction"
Expand Down
1 change: 0 additions & 1 deletion test/unit/wizards/__snapshots__/optfields.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ snapshots["Wizards for SCL OptFields element define an edit wizard that looks li
>
</mwc-button>
<mwc-button
dialoginitialfocus=""
icon="save"
label="[save]"
slot="primaryAction"
Expand Down
Loading