Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: create oscd-layout addon #1510

Merged
merged 20 commits into from
May 2, 2024
Merged

chore: create oscd-layout addon #1510

merged 20 commits into from
May 2, 2024
+1,990 −1,828

Conversation

juancho0202
Copy link
Contributor

@juancho0202 juancho0202 commented Apr 24, 2024 •
edited
Loading

Some decisions taken here that I think award a discussion:

  • former Plugging mixin rendering functionality was separated into the oscd-layout addon
    • snapshot test which kept track of the hosting UI and plugins is now under a separate snapshot test for the layout addon
  • a "position: absolute; top: 0" style was added to the mwc-drawer to stick it to the top
  • the private get plugins array was awarded a @State annotation and a setter in order to use Lit's reactivity (plus I added a requestUpdate on the open-scd tag whenever someone adds a new external plugin)

@juancho0202
chore: create oscd-layout addon...
437ac72 
- extracts all rendering UI logic including former Hosting mixin and Plugging mixin to the layout addon
- creates new events to connect layout addon to plugging loading functionality

Signed-off-by: Juan Munoz <juancho0202@gmail.com>
@juancho0202
chore: fixes tests broken with refactor
e5b9ac8 
Signed-off-by: Juan Munoz <juancho0202@gmail.com>
@juancho0202 juancho0202 linked an issue Apr 24, 2024 that may be closed by this pull request
Create <oscd-layout> addon #1466
Closed
juancho0202 and others added 5 commits April 24, 2024 09:40
@juancho0202
Merge branch 'main' into 1466-create-oscd-layout-addon
ce88778
@juancho0202
chore: adding missing <slot> tag to addon to allow composing
ece72a2 
Signed-off-by: Juan Munoz <juancho0202@gmail.com>
@juancho0202
chore: updating mock-open-scd to comply with new rendering logic
dca0fb2 
Signed-off-by: Juan Munoz <juancho0202@gmail.com>
@juancho0202
chore: adding snapshot testing for layout
25433da 
Signed-off-by: Juan Munoz <juancho0202@gmail.com>
@juancho0202
chore: improving render functions' encapsulation and adding typedoc c…
87df4df 
…omments

Signed-off-by: Juan Munoz <juancho0202@gmail.com>
@juancho0202 juancho0202 marked this pull request as ready for review April 24, 2024 15:30
juancho0202 added 3 commits May 1, 2024 13:06
@juancho0202
chore: include missing editCount prop on layout addon
5846760 
Signed-off-by: Juan Munoz <juancho0202@gmail.com>
@juancho0202
Merge branch 'main' into 1466-create-oscd-layout-addon
ae11f1c 
Signed-off-by: Juan Munoz <juancho0202@gmail.com>
@juancho0202
Merge branch 'main' into 1466-create-oscd-layout-addon
ababce3 
Signed-off-by: Juan Munoz <juancho0202@gmail.com>
pascalwilbrink
pascalwilbrink reviewed May 1, 2024
View reviewed changes
packages/open-scd/src/addons/Layout.ts Outdated Show resolved Hide resolved
packages/open-scd/src/addons/Layout.ts Outdated Show resolved Hide resolved
packages/open-scd/src/addons/Layout.ts Outdated Show resolved Hide resolved
packages/open-scd/src/addons/Layout.ts Outdated Show resolved Hide resolved
packages/open-scd/src/addons/Layout.ts Outdated Show resolved Hide resolved
packages/open-scd/src/addons/Layout.ts Outdated Show resolved Hide resolved
packages/open-scd/src/addons/Layout.ts Outdated Show resolved Hide resolved
packages/open-scd/src/addons/Layout.ts Outdated Show resolved Hide resolved
packages/open-scd/src/addons/Layout.ts Show resolved Hide resolved
juancho0202 and others added 9 commits May 1, 2024 15:53
@juancho0202 @pascalwilbrink
chore: modify import to get type declaration only
fa20f33 
Co-authored-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
@juancho0202 @pascalwilbrink
chore: modify import to get type declaration only
2777670 
Co-authored-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
@juancho0202 @pascalwilbrink
chore: modify import to get type declaration only
cb42c37 
Co-authored-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
@juancho0202 @pascalwilbrink
chore: modify import to get type declaration only
fc92dd2 
Co-authored-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
@juancho0202 @pascalwilbrink
chore: modify import to get type declaration only
99c8727 
Co-authored-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
@juancho0202 @pascalwilbrink
chore: modify import to get type declaration only
e419c2a 
Co-authored-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
@juancho0202 @pascalwilbrink
chore: modify import to get type declaration only
b7698a4 
Co-authored-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
@juancho0202 @pascalwilbrink
chore: modify import to get type declaration only
01e9735 
Co-authored-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
@juancho0202 @pascalwilbrink
chore: add missing imports
1f9d7fb 
Co-authored-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
@juancho0202 juancho0202 requested a review from pascalwilbrink May 1, 2024 13:55
@juancho0202
chore: import List class needed for instanceof validation
a7392d4 
Signed-off-by: Juan Munoz <juancho0202@gmail.com>
pascalwilbrink
pascalwilbrink approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@pascalwilbrink pascalwilbrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pascalwilbrink pascalwilbrink merged commit 55d06d3 into main May 2, 2024
5 checks passed
@pascalwilbrink pascalwilbrink deleted the 1466-create-oscd-layout-addon branch May 2, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwilbrink pascalwilbrink pascalwilbrink approved these changes

@trusz trusz Awaiting requested review from trusz

Assignees
No one assigned
Labels
None yet
Projects
PR Overview
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create <oscd-layout> addon
2 participants
@juancho0202 @pascalwilbrink