chore: moving events, interfaces and types to @openscd/core #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- places api into folder "foundation/deprecated" - (does not include code related to wizards or scl library) Signed-off-by: Juan Munoz <juancho0202@gmail.com>
- duplicate entries without file extensions were necessary to overcome snowpack errors when building open-scd Signed-off-by: Juan Munoz <juancho0202@gmail.com>
Signed-off-by: Juan Munoz <juancho0202@gmail.com>
Signed-off-by: Juan Munoz <juancho0202@gmail.com>
Signed-off-by: Juan Munoz <juancho0202@gmail.com>
|
not a small PR :D |
I've done it manually, since it is not a change of the code itself but it's just some lines being moved from one file to the other, I expect the current tests with the updated imports to be enough. Fun fact: 176 files only changed their import statements. |
|
Maybe interesting to discuss this in the review as well #1476 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1476