feat: add missing editor icons #1495
Conversation
Signed-off-by: Steffen van den Driest <steffen.van.den.driest@alliander.com>
|
As discussed, this PR contains adding icons to the following substation plugin editors:
|
packages/plugins/src/editors/substation/transformer-winding-editor.ts
Outdated
Show resolved
Hide resolved
packages/plugins/src/editors/substation/voltage-level-editor.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Steffen van den Driest <steffen.van.den.driest@alliander.com>
|
Thanks for your review @pascalwilbrink! I agree, the styles variable should take care of the styling. I added a CSS class to the styles and made these icons part of that class. I also included the other editors of the substation plugin that had this inline styling. |
|
Is this feature already released on openscd.github.io? |
|
@Sander3003 currently the workflow for releasing to openscd.github.io is broken, I attempted a fix last week but it missed one detail, I already identified the missing bit and successfully deployed with the same workflow in my personal fork of openscd (juancho0202.github.io). I will talk to @trusz today about it and see if we can merge the new fix. |
closes #1229