Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: splitting up open-scd and plugins #1469

Merged
merged 12 commits into from
Mar 14, 2024
Merged

fix: splitting up open-scd and plugins #1469

merged 12 commits into from
Mar 14, 2024

Conversation

Stef3st
Copy link
Contributor

@Stef3st Stef3st commented Mar 11, 2024

closes #1419

@Stef3st Stef3st self-assigned this Mar 11, 2024
@Stef3st Stef3st linked an issue Mar 11, 2024 that may be closed by this pull request
Split up OpenSCD/openscd into 2 packages #1419
Closed
3 tasks
Stef3st and others added 4 commits March 11, 2024 15:37
@Stef3st
Merge branch 'main' into 1419-split-up-openscdopenscd-into-2-packages
cd5d5df
@Stef3st
chore: changed package-lock
01c5cdd 
Signed-off-by: Steffen van den Driest <steffen.van.den.driest@alliander.com>
@Stef3st
chore: added panzoom dependency
22e2fcb 
Signed-off-by: Steffen van den Driest <steffen.van.den.driest@alliander.com>
@Stef3st
chore: added missing dependencies
8e1e81a 
Signed-off-by: Steffen van den Driest <steffen.van.den.driest@alliander.com>
@Stef3st Stef3st marked this pull request as ready for review March 12, 2024 10:46
pascalwilbrink
pascalwilbrink reviewed Mar 12, 2024
View reviewed changes
packages/plugins/sw.js Outdated Show resolved Hide resolved
packages/plugins/README.md Outdated Show resolved Hide resolved
packages/plugins/package.json Show resolved Hide resolved
@pascalwilbrink
Copy link
Member

The folder google inside plugins can be removed

Stef3st and others added 4 commits March 12, 2024 14:18
@Stef3st @pascalwilbrink
Update packages/plugins/README.md
2e74383 
Co-authored-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
@Stef3st @pascalwilbrink
Update packages/plugins/package.json
fc19f97 
Co-authored-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
@Stef3st
chore: removed sw from plugins
b10adcd 
Signed-off-by: Steffen van den Driest <steffen.van.den.driest@alliander.com>
@Stef3st
chore: removed google folder from plugins
d0d5816
@Stef3st Stef3st requested a review from pascalwilbrink March 13, 2024 10:39
pascalwilbrink
pascalwilbrink reviewed Mar 13, 2024
View reviewed changes
packages/open-scd/test/unit/action-pane.test.ts Show resolved Hide resolved
packages/plugins/package.json Outdated Show resolved Hide resolved
packages/plugins/package.json Show resolved Hide resolved
packages/open-scd/package.json Outdated Show resolved Hide resolved
Stef3st added 2 commits March 14, 2024 09:16
@Stef3st
chore: altered action pane test
07557db
@Stef3st
chore: removed start and added bundle
b90b21a 
Signed-off-by: Steffen van den Driest <steffen.van.den.driest@alliander.com>
@Stef3st Stef3st requested a review from pascalwilbrink March 14, 2024 09:20
@Stef3st
chore: add include to tsconfig
1be52ab 
Signed-off-by: Steffen van den Driest <steffen.van.den.driest@alliander.com>
@Stef3st Stef3st merged commit 200c030 into main Mar 14, 2024
6 checks passed
@Stef3st Stef3st deleted the 1419-split-up-openscdopenscd-into-2-packages branch March 14, 2024 14:29
@github-actions github-actions bot mentioned this pull request Mar 19, 2024
Closed
@github-actions github-actions bot mentioned this pull request Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwilbrink pascalwilbrink pascalwilbrink approved these changes

@juancho0202 juancho0202 Awaiting requested review from juancho0202

@trusz trusz Awaiting requested review from trusz

Assignees

@Stef3st Stef3st

Labels
None yet
Projects
PR Overview
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split up OpenSCD/openscd into 2 packages
2 participants
@Stef3st @pascalwilbrink