Editor addon #1449
Merged
Editor addon #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rDataBinding.test.js
…rLaterBinding.test.js
…rMessageBinding.test.js
…ataBinding.test.js
…aterBinding.test.js
…essageBinding.test.js
Stef3st
suggested changes
Mar 7, 2024
There was a problem hiding this comment.
Looks good. I do have a few remarks on files that aren't altered but now can be, because of this solution:
-
mock-wizard-editor and mock-editor should no longer have to rely on the Editing mixin and can be altered to the Editor addon. I understand that the mock-editor-logger and mock-setter-logger still require the Editing mixin because the Historing depends on that.
-
The Wizarding mixin can be deleted. It's no longer being used.
Finally, unfortunatly the Plugin tests keep failing. I have the same issue locally on my machine at first try, when I retry the tests pass. It looks like a timing/sync issue somewhere.
Co-authored-by: Steffen van den Driest <35229971+Stef3st@users.noreply.github.com>
Stef3st
reviewed
Mar 8, 2024
packages/open-scd/test/integration/editors/SMVSubscriberMessageBinding.test.ts
Show resolved
Hide resolved
Stef3st
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.