Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wizarding addon #1446

Merged
merged 38 commits into from
Mar 4, 2024
Merged

Wizarding addon #1446

merged 38 commits into from
Mar 4, 2024

Conversation

pascalwilbrink
Copy link
Member

No description provided.

@pascalwilbrink
Feat: Added Waiter addon
e236204
@pascalwilbrink
Fix: removed console.log
26a362f
@pascalwilbrink
Fix: Removed .workdone
2a284a2
@pascalwilbrink
Fix: Removed waiting from OpenSCD
5541386
@pascalwilbrink
Fix: Added deferred promise to open-scd.test
137612e
@pascalwilbrink
Fix: Added deferred promise to open-scd.test
5f11fd8
@pascalwilbrink
Fix: fixed E2E test
12fc4d7
@pascalwilbrink
Removed waiting mixin
563d4c8
@pascalwilbrink
Feat: Settings addon
1a1c195
@pascalwilbrink
Fix: fixed test
b833f9f
@pascalwilbrink
Fix: updated import in themes.ts
e3d1515
@pascalwilbrink
Fix: updated import in themes.ts
4960d04
@pascalwilbrink
Feat: Moved hosting into OpenSCD class
d051c91
@pascalwilbrink
Removed Hosting Mixin
7a84fa2
@pascalwilbrink
Removed console.log
e997916
@pascalwilbrink
Feat: Removed custom webcomponent definition in tests
2a5bc49
@pascalwilbrink
Fixed some tests
7d4a6be
@pascalwilbrink
Fixed more tests
1d81b5a
@pascalwilbrink
Fixed tests
9e92087
@pascalwilbrink
Updated timeout
a3470b7
@pascalwilbrink
Removed dist folders
4742434
@pascalwilbrink
Removed dist folder
7cf43b8
@pascalwilbrink
Fixed tests
ebf3714
@pascalwilbrink
Renamed wizarding.test.ts
17d0605
@pascalwilbrink
Fix: Fixed some other tests
328d490
@pascalwilbrink
Removed dist folders
bd46e84
@pascalwilbrink
Removed dist folder
514b04d
@pascalwilbrink
Removed console.logs
e51a3f9
@pascalwilbrink
Fixed merge conflicts
e59b1a3
@pascalwilbrink
Fixed merge conflicts
669d07d
@pascalwilbrink pascalwilbrink marked this pull request as ready for review February 29, 2024 10:01
Stef3st
Stef3st suggested changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@Stef3st Stef3st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Few minor things

packages/open-scd/test/mock-wizard-editor.ts Outdated Show resolved Hide resolved
packages/open-scd/test/unit/wizards/connectedap-c.test.ts Outdated Show resolved Hide resolved
@Stef3st Stef3st merged commit 160248c into main Mar 4, 2024
5 checks passed
@Stef3st Stef3st deleted the Wizarding_Addon branch March 4, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stef3st Stef3st Stef3st approved these changes

Assignees
No one assigned
Labels
None yet
Projects
PR Overview
Status: Approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pascalwilbrink @Stef3st