Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Added Waiter addon #1439

Merged
merged 12 commits into from
Feb 22, 2024
Merged

Feat: Added Waiter addon #1439

merged 12 commits into from
Feb 22, 2024

Conversation

pascalwilbrink
Copy link
Member

No description provided.

@pascalwilbrink pascalwilbrink marked this pull request as ready for review February 13, 2024 10:12
@pascalwilbrink pascalwilbrink changed the title Feat: Added Waiter addon Feat: Added Waiter addon 1 Feb 15, 2024
@pascalwilbrink pascalwilbrink changed the title Feat: Added Waiter addon 1 Feat: Added Waiter addon Feb 15, 2024
@juancho0202
Copy link
Contributor

@pascalwilbrink is there any reason you use override in your render method in packages/open-scd/src/addons/Waiter.ts ?? It seems to be causing a building error

@pascalwilbrink
Copy link
Member Author

@pascalwilbrink is there any reason you use override in your render method in packages/open-scd/src/addons/Waiter.ts ?? It seems to be causing a building error

Not really, it failed because it's added in TS 3.4 (i think) and building uses an older version. Removed it

juancho0202
juancho0202 approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@juancho0202 juancho0202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@pascalwilbrink pascalwilbrink merged commit 91a2ca9 into main Feb 22, 2024
4 checks passed
@pascalwilbrink pascalwilbrink deleted the Waiter_Addon branch February 22, 2024 07:56
@github-actions github-actions bot mentioned this pull request Mar 19, 2024
Closed
@github-actions github-actions bot mentioned this pull request Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juancho0202 juancho0202 juancho0202 approved these changes

@trusz trusz Awaiting requested review from trusz

@Stef3st Stef3st Awaiting requested review from Stef3st

Assignees
No one assigned
Labels
None yet
Projects
PR Overview
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pascalwilbrink @juancho0202