Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split logging #1334

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Split logging #1334

merged 6 commits into from
Oct 31, 2023

Conversation

pascalwilbrink
Copy link
Member

@pascalwilbrink pascalwilbrink commented Oct 19, 2023 •
edited
Loading

fixes #1328

@pascalwilbrink pascalwilbrink marked this pull request as ready for review October 19, 2023 13:42
juancho0202
juancho0202 suggested changes Oct 24, 2023
View reviewed changes
packages/open-scd/src/Historing.ts Outdated Show resolved Hide resolved
packages/open-scd/src/Historing.ts Show resolved Hide resolved
pascalwilbrink and others added 2 commits October 24, 2023 17:23
@juancho0202
Copy link
Contributor

LGTM!

@pascalwilbrink pascalwilbrink merged commit 370f47a into main Oct 31, 2023
@pascalwilbrink pascalwilbrink deleted the Split_Logging branch October 31, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juancho0202 juancho0202 juancho0202 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
PR Overview
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split up the Logging Mixin into 2 Mixins
2 participants
@pascalwilbrink @juancho0202