Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow address update for new entries #1331

Merged
merged 3 commits into from
Nov 7, 2023
Merged

fix: allow address update for new entries #1331

merged 3 commits into from
Nov 7, 2023

Conversation

Stef3st
Copy link
Contributor

@Stef3st Stef3st commented Oct 18, 2023

closes #1327

@Stef3st
fix: allow address update for new entries
1602289 
Signed-off-by: Stef3st <steffen.van.den.driest@alliander.com>
@Stef3st Stef3st self-assigned this Oct 18, 2023
@Stef3st Stef3st linked an issue Oct 18, 2023 that may be closed by this pull request
Can no longer save VLAN-ID and VLAN-Priority in Wizard #1327
Closed
@Stef3st
Copy link
Contributor Author

Stef3st commented Oct 18, 2023

in GSE the MAC-Address/APPID/VLAN-ID/VLAN-PRIORITY are put in the addressContent array. When saving the old and the new addressContent gets compared but only check the already existing P types. It doesn't take into account newly added P types.

JakobVogelsang
JakobVogelsang previously requested changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@JakobVogelsang JakobVogelsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am missing a regression test here. We need to make sure this error will not re-appear in the future once again.

@Stef3st
chore: added tests
c194a73 
Signed-off-by: Stef3st <steffen.van.den.driest@alliander.com>
JakobVogelsang
JakobVogelsang approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@JakobVogelsang JakobVogelsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stef3st Stef3st merged commit d1f4ff9 into main Nov 7, 2023
@Stef3st Stef3st deleted the 1327-can-no-longer-save-vlan-id-and-vlan-priority-in-wizard branch November 7, 2023 14:05
@github-actions github-actions bot mentioned this pull request Mar 19, 2024
Closed
@github-actions github-actions bot mentioned this pull request Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakobVogelsang JakobVogelsang JakobVogelsang approved these changes

@danyill danyill Awaiting requested review from danyill

Assignees

@Stef3st Stef3st

Labels
None yet
Projects
PR Overview
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can no longer save VLAN-ID and VLAN-Priority in Wizard
2 participants
@Stef3st @JakobVogelsang