-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(editing): use editCount property for change propagation #1233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for attending to this important matter, I am most grateful 👍 💌
I have rebased #1222 on this PR and found that it resolves the errors and issues encountered there. I now am able to import all IEDs without any failures (silent or console errors) on both Chrome and Firefox.
I have done limited testing of plugins and not found any regressions.
97673f7
to
ddee296
Compare
SonarCloud Quality Gate failed.
|
@ca-d what is the status of this pull-request? |
@Sander3003 there's an intermittent timing error in the tests (see currently failing test on test&build while regular test runs) that nobody has fixed yet. This currently needs help. |
Also SonarCloud seems to be complaining about something, might be worth checking out. |
Signed-off-by: Stef3st <steffen.van.den.driest@alliander.com>
Signed-off-by: Stef3st <steffen.van.den.driest@alliander.com>
Signed-off-by: Stef3st <steffen.van.den.driest@alliander.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for looking at the tests @Stef3st
I'd quite like to see this merged soon - is this something you'd like to do @ca-d, I'm happy to merge unless you'd like to review the latest changes. |
This fixes several issues related to replacing our document by already moving to the open-scd-core way of propagating change to plugins: an
editCount
representing where we are in the edit history, which is passed in addition to thedocName
anddoc
.