Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(foundation) improve ExtRef identity function #1182

Merged
merged 4 commits into from
Feb 27, 2023

Conversation

danyill
Copy link
Collaborator

@danyill danyill commented Feb 22, 2023

Closes #1179

Happy to withdraw this PR if it doesn't pass refinement.
This would be helpful for me in the subscriber view for later binding.

A review would be gratefully accepted.

Copy link
Contributor

@ca-d ca-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you very much for this contribution, I think it would also be fair to classify this as fix: rather than feat:, do you agree?

@danyill danyill changed the title feat(foundation) improve ExtRef identity function fix(foundation) improve ExtRef identity function Feb 27, 2023
@danyill
Copy link
Collaborator Author

danyill commented Feb 27, 2023

LGTM

Thank you very much for this contribution, I think it would also be fair to classify this as fix: rather than feat:, do you agree?

It shall be as you wish and thank you for the review 👍

@danyill danyill merged commit 7118454 into openscd:main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve ExtRef identity function
2 participants