feat(editors/binding): Allow filtering of subscribed/unsubscribed data in binding editors

[danyill]

Closes #1062

Draft until we agree if any of this is a good idea, and I will add some tests.

I'm not comfortable with the filter button being somewhat shaded when the section is selected, and the background colour darkens. I have tried to deal with it as best I can, but perhaps there is a better way.

It also doesn't entirely play nicely when "Not Subscribed" is selected and the user does subscriptions (the activated item becomes hidden). Maybe we don't need this option?

[JakobVogelsang]

The code looks good. There is only one thing that I would want to be changed:

• On my Mac when I select the first item the button has a different color compared to selecting the second choice.

Another one thing is debatable and I leave it up to you:

• when no FCDA is viable also do not show the control block. With many control blocks in the file this effect of this filter is lost. This could be possible with simple CSS rule I feel

[JakobVogelsang]

Thank you @danyill for your wonderful contribution to that thing that we are all working on.

[danyill]

• On my Mac when I select the first item the button has a different color compared to selecting the second choice.

I don't see that - can you provide a screenshot?

Here is what I see:

• when no FCDA is viable also do not show the control block. With many control blocks in the file this effect of this filter is lost. This could be possible with simple CSS rule I feel

Yes, good suggestion - let's do that.

[danyill]

when no FCDA is viable also do not show the control block. With many control blocks in the file this effect of this filter is lost. This could be possible with simple CSS rule I feel

The CSS is kind of simple but for my weak mind it was not so simple...

I take a moment to pity my reviewer. 🙏

This table may help my reviewer! It helped me...

KS = Keep Subscribed (Show Subscribed)
KNS = Keep Not Subscribed (Show Not Subscribed)

OTOH although it seems complex to me it is blindingly fast which I like. ❤️‍🔥 🐎

[danyill]

OK, after making the review changes I am much happier with the outcome.

I have implemented local storage so the filter selection isn't ephemeral.
Part of using a boolean attribute means I must default to false so the states must be inverted which can be confusing to think about.

I use accessors for holding the filter state so I can use other properties to create a unique identifier for local storage.

[danyill]

Thank you for these review comments, the product is greatly improved. 🎉

This is ready for some more testing and review.

If we are happy, then I can add some brief integration tests for the four plugins where it is used.

I'll also do something similar to this in #1187 for the subscriber-oriented view.

[danyill]

I have tried to add some initial tests, but they are not working - and so far I cannot see why. Could I ask you to take a look at these please?

[danyill]

I have tried to add some initial tests, but they are not working - and so far I cannot see why. Could I ask you to take a look at these please?

I have figured out the reasons for this, finally...

Addressed in re-worked updates

[danyill]

I have finally resolved the issues with tests and would be grateful for a review of this.
Sorry for the messy commit history. There were a few mis-steps made amid some confusion but eventually I straightened myself out 😉

I will be happy to take another review and make further improvements as required.

[danyill]

I think Jakob is unavailable for some time. I'd be very pleased to receive a review on this so I can incorporate it into my subscriber view which will be similar.

I've nominated a few people and I would be happy to discuss/go through it if anyone is interested or available to look at this.

[juancho0202]

LGTM!

[juancho0202]

hey @danyill please merge main back into your branch 😬

[danyill]

Thank you for the assistance on this PR and the detailed review. 👏