Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(../substation/general-equipment-editor.ts):action-icon_is_rendered #1122

Merged
merged 2 commits into from
Jan 10, 2023
Merged

fix(../substation/general-equipment-editor.ts):action-icon_is_rendered #1122

merged 2 commits into from
Jan 10, 2023

Conversation

marcvanraalte
Copy link
Contributor

@marcvanraalte marcvanraalte commented Jan 9, 2023 •
edited by JakobVogelsang
Loading

Closes #1114

JakobVogelsang
JakobVogelsang requested changes Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@JakobVogelsang JakobVogelsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not rendered correctly. The icon is there, but the buttons are rendered incorrect.

grafik

JakobVogelsang
JakobVogelsang approved these changes Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@JakobVogelsang JakobVogelsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcvanraalte marcvanraalte merged commit 598988b into main Jan 10, 2023
@marcvanraalte marcvanraalte deleted the 1114_GenEq_not_rendered_as_icon branch January 10, 2023 08:08
@marcvanraalte
Copy link
Contributor Author

#1122 closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakobVogelsang JakobVogelsang JakobVogelsang approved these changes

@juancho0202 juancho0202 Awaiting requested review from juancho0202

@pascalwilbrink pascalwilbrink Awaiting requested review from pascalwilbrink

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GeneralEquipment editor is not rendered as icon
2 participants
@marcvanraalte @JakobVogelsang