feat(wizards/generalequipment): Add_create_wizard_GeneralEquipment_and_test

[marcvanraalte]

No description provided.

[JakobVogelsang]

Some naming is inconsistent and need to be changed

[marcvanraalte]

Hi Jakob, Thanks for your reviews. However this one is not really clear to me. What do you want me to do? I added the missing test it('does not accept invalid type attribute', async () => { Do I overlook something...? Please let me know. Greetings, Marc Van: Jakob Vogelsang ***@***.***> Verzonden: donderdag 22 december 2022 11:33 Aan: openscd/open-scd ***@***.***> CC: Marc van Raalte ***@***.***>; Author ***@***.***> Onderwerp: Re: [openscd/open-scd] feat(wizards/generalequipment): Add_create_wizard_GeneralEquipment_and_test (PR #1102) @JakobVogelsang commented on this pull request.

________________________________ In test/unit/wizards/generalequipment.test.ts<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenscd%2Fopen-scd%2Fpull%2F1102%23discussion_r1055321019&data=05%7C01%7Cmarc.van.raalte%40alliander.com%7C6c7e6b90cc6749ffa12b08dae407f1fd%7C697f104bd7cb48c8ac9fbd87105bafdc%7C0%7C0%7C638073020021957864%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=iyS%2Fms5mJv7cQvDgJktnn0lHH%2BVSktiWazwAGTBp7wo%3D&reserved=0>:

@@ -108,25 +213,6 @@ describe('Wizards for SCL GeneralEquipment element', () => {

expect(actionEvent).to.not.have.been.called; }); - it('does not accept invalid type attribute', async () => { This removal is still in the code. Why are those tests removed. They seem to be reasonable? - Reply to this email directly, view it on GitHub<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenscd%2Fopen-scd%2Fpull%2F1102%23discussion_r1055321019&data=05%7C01%7Cmarc.van.raalte%40alliander.com%7C6c7e6b90cc6749ffa12b08dae407f1fd%7C697f104bd7cb48c8ac9fbd87105bafdc%7C0%7C0%7C638073020021957864%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=iyS%2Fms5mJv7cQvDgJktnn0lHH%2BVSktiWazwAGTBp7wo%3D&reserved=0>, or unsubscribe<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAUTHWWW46UE7MN4IRAH4DJDWOQU65ANCNFSM6AAAAAASVG5CQY&data=05%7C01%7Cmarc.van.raalte%40alliander.com%7C6c7e6b90cc6749ffa12b08dae407f1fd%7C697f104bd7cb48c8ac9fbd87105bafdc%7C0%7C0%7C638073020021957864%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=TUST2Js1lqv1VNdCp%2B2bHJrGFH9C8ctVukonjf3pq1E%3D&reserved=0>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>

[JakobVogelsang]

LGTM