fix(subscription) Coalesce lack of prefix to empty string, allow no prefix in FCDA description #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlabordus
reviewed
Nov 14, 2022
dlabordus
approved these changes
Nov 16, 2022
|
Thank you for this review 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1076
The code I am touching was only added recently so the reason may be nearby
I think
ldInstis almost always part of an FCDA (GSSE being mostly dead/unused) but prefix maybe not, it is optional in Table 22 of IEC 61850-6 Ed 2.1So I don't fully understand this code path but this should get rid of the word null.