Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create avro spec for v 2.2 #57

Open
wants to merge 2 commits into
base: 2.0
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Jun 18, 2014

move 2.1 version into org.openrtb.common.api.v_2_1 so that we can also create org.openrtb.common.api.v_2_2

@chompi
Copy link
Collaborator

chompi commented Jun 20, 2014

Hi Unruly Developer :)

I appreciate your work to update the Avro protocol files to match 2.2.
Thank you for that.

Why can't we just create a branch for 2.2 as opposed to embedding version
information in the API protocol file names? Also, you could add a version
tag inside the protocol file (Avro allows that). Any thoughts?

Best
Pankaj

On Wed, Jun 18, 2014 at 11:43 AM, Unruly Developers <
notifications@github.com> wrote:

move 2.1 version into org.openrtb.common.api.v_2_1 so that we can also

create org.openrtb.common.api.v_2_2

You can merge this Pull Request by running

git pull https://github.com/devunrulymedia/openrtb2x versions_2_2

Or view, comment on, or merge it at:

#57
Commit Summary

  • move 2.1 version into org.openrtb.common.api.v_2_1 so that we can
    also create org.openrtb.common.api.v_2_2

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#57.

Pankaj Shroff
shroffG@Gmail.com

@ghost
Copy link
Author

ghost commented Jun 20, 2014

Hi Pankaj,

We wanted to be able to support more than one version of the spec for integrating with different partners. If we namespace them this way, it's pretty easy to do that, we just have to be able to work out which one somebody is supplying us, and as you said, that's relatively easy. If we try to rely on maven versioning, we'll be unable to have more than one version in any given class loader.

Clive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant