[orx-midi] provide an alternative for when a device is missing, better logging #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Different devices use different channels. Some devices use multiple channels.
edwinRNDR
reviewed
May 22, 2023
| @@ -294,4 +295,39 @@ fun Program.openMidiDevice(name: String): MidiTransceiver { | |||
| val actualName = matchingDevice?.name ?: name | |||
|
|
|||
| return MidiTransceiver.fromDeviceVendor(this, actualName) | |||
There was a problem hiding this comment.
Can openMidiDevice be implemented using return openMidiDevilceOrNull(name) ?: error("no MIDI device found for query '$name'") . This has the benefit of clearer error messages.
There was a problem hiding this comment.
How does 6d2a4c5 look like?
Should all throws be error? Or leave them as they were?
Mention MIDI in other messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.