Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support inner classes for groovy #4825

Merged
merged 9 commits into from
Jan 2, 2025

Conversation

jevanlingen
Copy link
Contributor

@jevanlingen jevanlingen commented Dec 31, 2024

What's changed?

Inner classes our now totally supported (including anonymous classes).

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Most work to support inner classes was already done, the new code just adds some missing pieces.

Any additional context

To support

a visitConstructor was added. The code was 95% the same as the visitMethod. So I merged the visitMethod and visitConstructor again (a ConstructorNode extends a MethodNode, so visitMethod is enough).

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@jevanlingen jevanlingen linked an issue Dec 31, 2024 that may be closed by this pull request
github-actions[bot]

This comment was marked as resolved.

github-actions[bot]

This comment was marked as resolved.

github-actions[bot]

This comment was marked as resolved.

github-actions[bot]

This comment was marked as resolved.

github-actions[bot]

This comment was marked as resolved.

github-actions[bot]

This comment was marked as resolved.

@jevanlingen jevanlingen mentioned this pull request Jan 2, 2025
3 tasks
@jevanlingen jevanlingen merged commit 1aee2af into main Jan 2, 2025
2 checks passed
@jevanlingen jevanlingen deleted the 4063-support-for-inner-classes-in-groovy branch January 2, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support for inner classes in Groovy
2 participants