Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gradle/Groovy parser issue related to Java class references #4742

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Fix Gradle/Groovy parser issue related to Java class references #4742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rewrite-groovy/src/main/java/org/openrewrite/groovy/GroovyParserVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1374,7 +1374,7 @@ public void visitConstantExpression(ConstantExpression expression) {
public void visitConstructorCallExpression(ConstructorCallExpression ctor) {
queue.add(insideParentheses(ctor, fmt -> {
cursor += 3; // skip "new"
TypeTree clazz = visitTypeTree(ctor.getType(), ctor.getMetaDataMap().containsKey(StaticTypesMarker.INFERRED_TYPE));
TypeTree clazz = visitTypeTree(ctor.getType(), ctor.getNodeMetaData().containsKey(StaticTypesMarker.INFERRED_TYPE));
Copy link
Contributor Author

@Laurens-W Laurens-W Dec 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rewrite/rewrite-groovy/src/main/java/org/openrewrite/groovy/GroovyParserVisitor.java

Line 1383 in c6d1f60

MethodNode methodNode = (MethodNode) ctor.getNodeMetaData().get(StaticTypesMarker.DIRECT_METHOD_CALL_TARGET);

Same way of retrieving the metadata is used a few lines later

JContainer<Expression> args = visit(ctor.getArguments());
J.Block body = null;
if (ctor.isUsingAnonymousInnerClass() && ctor.getType() instanceof InnerClassNode) {
Expand Down
Loading