Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to find a GitRemote.RemoteServer registered to the GitRemote.Parser #4436

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

pstreef
Copy link
Contributor

@pstreef pstreef commented Aug 22, 2024

What's changed?

Add a method to find out if a remote server is registered by (possibly not normalized) origin

What's your motivation?

Knowledge is power

Anything in particular you'd like reviewers to focus on?

Am I using @Nullable like the cool kids do?

Anyone you would like to review specifically?

@timtebeek @bryceatmoderne

Have you considered any alternatives or workarounds?

guessing if a server is registered by random dice roll

Any additional context

no

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@pstreef pstreef changed the title feat: Add method to find a GitRemote.RemoteServer registered to the GitRemote.Parser Add method to find a GitRemote.RemoteServer registered to the GitRemote.Parser Aug 22, 2024
@pstreef pstreef self-assigned this Aug 22, 2024
@pstreef pstreef added the enhancement New feature or request label Aug 22, 2024
@pstreef pstreef merged commit bfb045b into main Aug 22, 2024
2 checks passed
@pstreef pstreef deleted the feat/add-find-remote-service-method branch August 22, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants