-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed maven multi module property version problem #4335
Fixed maven multi module property version problem #4335
Conversation
… just the parent version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- rewrite-core/src/test/java/org/openrewrite/RecipeListTest.java
- lines 35-35
- lines 66-69
- rewrite-maven/src/test/java/org/openrewrite/maven/trait/MavenPluginTest.java
- lines 26-26
Thanks for coming through with the fix here @marcel-gepardec! I must say it's great to see so many contributions from Gepardec come in lately. My only thought reviewing this one is that it would be great to have a unit test added to MavenParser similar to the one added this morning, referencing the issue #4319 that you had logged earlier. a34eacc?diff=unified&w=1 That way we can be sure this issue is fixed, and remains fixed even if there's future changes to the same lines of code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- rewrite-core/src/test/java/org/openrewrite/RecipeListTest.java
- lines 35-35
- lines 66-69
- rewrite-maven/src/test/java/org/openrewrite/maven/trait/MavenPluginTest.java
- lines 26-26
You're welcome. It's good to see that an open-source project has still someone responding as fast as you. Unfortunately, that's not normal nowadays. Regarding the test you mentioned, I added it accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see, thanks a lot once again, also for the kind comments.
rewrite-maven/src/test/java/org/openrewrite/maven/MavenParserTest.java
Outdated
Show resolved
Hide resolved
It looks like I'm not allowed to push the last remaining suggestions to this fork. Would it be possible to enable that on any next PR? That helps me with small final touches before a merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- rewrite-core/src/test/java/org/openrewrite/RecipeListTest.java
- lines 35-35
- lines 66-69
- rewrite-maven/src/test/java/org/openrewrite/maven/trait/MavenPluginTest.java
- lines 26-26
What's changed?
A property resolver has also been added to the project version, not only to the parent version.
What's your motivation?
As mentioned in the issue #4319 both poms do not change if there is a property inside the version. So I took the initiative and started looking for the error. It took me a while to figure it out, but now I get it.