Fix StackOverflowError in case of circular import deps #4284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if import dependency was already resolved before
To limit object allocations
|
Thanks for getting this started @ZhyliaievD ! I've updated your PR a bit to add additional assertions to your test that we indeed get merged. Would you mind double checking that you indeed expect |
|
Hi @timtebeek |
adastraperangusta
pushed a commit
to adastraperangusta/rewrite
that referenced
this pull request
Jul 2, 2024
) * Fix StackOverflowError in case of circular import deps Check if import dependency was already resolved before * Format test, remove unnecessary paths and add issue link * Replace Streams with for loop as per convention To limit object allocations * Swap argument order for consistency * Verify merged managed dependency version --------- Co-authored-by: Daniil Zhyliaiev <dzhyliaiev@playtika.com> Co-authored-by: Tim te Beek <tim@moderne.io>
timtebeek
added a commit
that referenced
this pull request
Jul 2, 2024
…ile (#4297) * avoid adding non-existent query as key in case the jsonpath is a query which yelds no result, avoid merging the yaml at end of file with the query as a key * Fix StackOverflowError in case of circular import deps (#4284) * Fix StackOverflowError in case of circular import deps Check if import dependency was already resolved before * Format test, remove unnecessary paths and add issue link * Replace Streams with for loop as per convention To limit object allocations * Swap argument order for consistency * Verify merged managed dependency version --------- Co-authored-by: Daniil Zhyliaiev <dzhyliaiev@playtika.com> Co-authored-by: Tim te Beek <tim@moderne.io> * Give EffectiveManagedDependencies a unique display name * Fix model updating to properly work with transitive dependencies. * Fix test expectation to not break when new versions of flyway-core are released * Deterministic ordering of new constraints * Further enhancements to UpdateGradleWrapper's ability to operate in contexts where services.gradle.org is unavailable * Also enforce that version numbers are literal, rather than dynamic selectors, when services.gradle.org cannot be reached * Fix typo in comment and apply formatter --------- Co-authored-by: Stef <stef.dev.49@gmail.com> Co-authored-by: Daniil Zhyliaiev <yangroang@gmail.com> Co-authored-by: Daniil Zhyliaiev <dzhyliaiev@playtika.com> Co-authored-by: Tim te Beek <tim@moderne.io> Co-authored-by: Sam Snyder <sam@moderne.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if import dependency was already resolved before
What's changed?
Add a check if import dependency was already resolved before
What's your motivation?
To avoid StackOverflowError in case of circular import deps
Fixes #4093
Checklist