Fix Parameterized is hidden by withFullyQualifiedName
#4245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com>
Parametrized is hidden by withFullyQualifiedNameParameterized is hidden by withFullyQualifiedName
rewrite-java/src/main/java/org/openrewrite/java/tree/JavaType.java
Outdated
Show resolved
Hide resolved
Signed-off-by: OlegDokuka <oleh@moderne.io>
knutwannheden
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
This PR ensures that withFullyQualifiedName never hides the original
Parametrizedtype, which includes info about generic paramsWhat's your motivation?
I noticed that bug, so I decided to fix it right away by PR
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist