Parse property values starting with the delimiter character #4065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid arithmetic operations with the state variable and rather assign the new value. Also convert to enum to make the states more easy to understand for the next author.
knutwannheden
approved these changes
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
In the state machine of the properties parser do not accept further delimiters after the first non escaped delimiter was found.
What's your motivation?
Fixes #4026.
Anything in particular you'd like reviewers to focus on?
The actual bug fix is in the first commit, so you may want to review it separately. The second commit removes all arithmetic from the state variable and gives readable names to the states to make debugging more simple for the next one looking into this.
Checklist