Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaParser should favor public classes when naming source inputs #4046

Merged

Conversation

ammachado
Copy link
Contributor

@ammachado ammachado commented Feb 24, 2024

What's changed?

This a follow-up on #4040, JavaParser should try to use public class names, when available.

What's your motivation?

Identified while testing #4030

Anything in particular you'd like reviewers to focus on?

No

Anyone you would like to review specifically?

No

Have you considered any alternatives or workarounds?

You can provide the correct source path when calling the Java Parser directly, but not when the parser is being called by a JavaTemplate.

Any additional context

No

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@ammachado ammachado marked this pull request as ready for review February 24, 2024 15:42
@timtebeek timtebeek added the bug Something isn't working label Feb 24, 2024
@timtebeek timtebeek merged commit 15e7361 into openrewrite:main Feb 24, 2024
1 check passed
@ammachado ammachado deleted the javaparser-should-use-public-class-names branch February 25, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants